Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 779943004: Enable telemetry unittests on Mac 10.9 (Closed)

Created:
6 years ago by sullivan
Modified:
6 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Enable telemetry unittests on Mac 10.9 The tests were fixed in https://codereview.chromium.org/789853003 BUG=423688 Committed: https://crrev.com/e0fe19f3e05e83e820be8a8e2850853bc0434b21 Cr-Commit-Position: refs/heads/master@{#307522}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M testing/buildbot/chromium.mac.json View 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
tonyg
lgtm Fingers crossed this time
6 years ago (2014-12-09 16:45:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/779943004/1
6 years ago (2014-12-09 16:47:09 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/29138)
6 years ago (2014-12-09 16:51:38 UTC) #6
sullivan
phajdan.jr, can do an owners review? This is reverting https://codereview.chromium.org/706703003, but since there so many ...
6 years ago (2014-12-09 16:58:19 UTC) #8
Paweł Hajdan Jr.
LGTM
6 years ago (2014-12-09 19:32:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/779943004/1
6 years ago (2014-12-09 19:37:36 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-09 19:45:38 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e0fe19f3e05e83e820be8a8e2850853bc0434b21 Cr-Commit-Position: refs/heads/master@{#307522}
6 years ago (2014-12-09 19:46:13 UTC) #13
sullivan
6 years ago (2014-12-09 21:35:17 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/792683002/ by sullivan@chromium.org.

The reason for reverting is: Tests fail with a different error..

Powered by Google App Engine
This is Rietveld 408576698