Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 706703003: Disable telemetry tests for Mac 10.9. (Closed)

Created:
6 years, 1 month ago by garykac
Modified:
6 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Disable telemetry tests for Mac 10.9. The telemetry tests are failing consistently on OSX 10.9. BUG=420615 R=tonyg@chromium.org Committed: https://crrev.com/5503de1eeae0437c1f8160d69b04d6241bc5e974 Cr-Commit-Position: refs/heads/master@{#303114}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove telemetry tests for Mac 10.9 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16 lines) Patch
M testing/buildbot/chromium.mac.json View 1 2 chunks +0 lines, -16 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
garykac
These tests are consistently failing on the Mac 10.9 bots, but I'm not sure about ...
6 years, 1 month ago (2014-11-06 00:01:55 UTC) #2
Paweł Hajdan Jr.
+Tony FYI https://codereview.chromium.org/706703003/diff/1/testing/buildbot/chromium.mac.json File testing/buildbot/chromium.mac.json (right): https://codereview.chromium.org/706703003/diff/1/testing/buildbot/chromium.mac.json#newcode283 testing/buildbot/chromium.mac.json:283: "name_disabled": "telemetry_unittests", Please don't invent syntax like ...
6 years, 1 month ago (2014-11-06 10:40:47 UTC) #4
garykac
On 2014/11/06 10:40:47, Paweł Hajdan Jr. wrote: > We may have to just remove these ...
6 years, 1 month ago (2014-11-06 18:33:19 UTC) #5
tonyg
lgtm
6 years, 1 month ago (2014-11-06 22:24:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/706703003/20001
6 years, 1 month ago (2014-11-06 22:25:13 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/22671)
6 years, 1 month ago (2014-11-06 22:31:38 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/5503de1eeae0437c1f8160d69b04d6241bc5e974 Cr-Commit-Position: refs/heads/master@{#303114}
6 years, 1 month ago (2014-11-06 23:03:53 UTC) #11
garykac
Committed patchset #2 (id:20001) manually as 5503de1eeae0437c1f8160d69b04d6241bc5e974.
6 years, 1 month ago (2014-11-06 23:03:54 UTC) #12
dtu
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/718783002/ by dtu@chromium.org. ...
6 years, 1 month ago (2014-11-11 20:21:07 UTC) #13
dtu
6 years, 1 month ago (2014-11-20 22:48:33 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/744283002/ by dtu@chromium.org.

The reason for reverting is: Second attempt to re-enable tests. I think there
may still be one test failure, but we can disable that one test. If there's more
than one, revert this..

Powered by Google App Engine
This is Rietveld 408576698