Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1020)

Unified Diff: pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart

Issue 779593002: Move elementAccess() from namer to emitter. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart
diff --git a/pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart b/pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart
index 437bdb15b761c8d8a400ae844080e7a6242ae617..77f7112a34bfa7b5e7d0873d2d3c8298cf86d3c8 100644
--- a/pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart
+++ b/pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart
@@ -83,7 +83,8 @@ class NsmEmitter extends CodeEmitterHelper {
assert(backend.isInterceptedName(Compiler.NO_SUCH_METHOD));
jsAst.Expression expression = js('this.#(this, #(#, #, #, #, #))', [
noSuchMethodName,
- namer.elementAccess(backend.getCreateInvocationMirror()),
+ backend.emitter.globalPropertyAccess(
floitsch 2014/12/03 17:02:25 I think staticFunctionAccess.
zarah 2014/12/05 08:22:51 Done.
+ backend.getCreateInvocationMirror()),
js.string(compiler.enableMinification ?
internalName : methodName),
js.string(internalName),
@@ -269,8 +270,8 @@ class NsmEmitter extends CodeEmitterHelper {
// Startup code that loops over the method names and puts handlers on the
// Object class to catch noSuchMethod invocations.
ClassElement objectClass = compiler.objectClass;
- jsAst.Expression createInvocationMirror = namer.elementAccess(
- backend.getCreateInvocationMirror());
+ jsAst.Expression createInvocationMirror = backend.emitter.
+ globalPropertyAccess(backend.getCreateInvocationMirror());
floitsch 2014/12/03 17:02:25 I prefer to put the "." on the second line: .glob
zarah 2014/12/05 08:22:51 Done.
String noSuchMethodName = namer.publicInstanceMethodNameByArity(
Compiler.NO_SUCH_METHOD, Compiler.NO_SUCH_METHOD_ARG_COUNT);
var type = 0;

Powered by Google App Engine
This is Rietveld 408576698