pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart - Issue 779593002: Move elementAccess() from namer to emitter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart

Issue 779593002: Move elementAccess() from namer to emitter. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart ('K') | « pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart ('k') | pkg/compiler/lib/src/js_emitter/old_emitter/type_test_emitter.dart » ('j') | pkg/compiler/lib/src/js_emitter/old_emitter/type_test_emitter.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart

diff --git a/pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart b/pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart

index 2db15c7c26286c0f4c8787b561d12b6fbb3f2915..53d2b4529e071fe74e5808d57cefff132a385580 100644

--- a/pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart

+++ b/pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart

@@ -318,7 +318,8 @@ List<jsAst.Statement> buildTearOffCode(JavaScriptBackend backend) {

if (closureFromTearOff != null) {

// We need both the AST that references [closureFromTearOff] and a string

// for the NoCsp version that constructs a function.

- tearOffAccessExpression = namer.elementAccess(closureFromTearOff);

+ tearOffAccessExpression =

+ backend.emitter.globalPropertyAccess(closureFromTearOff);

floitsch 2014/12/03 17:02:25 staticFunctionAccess

zarah 2014/12/05 08:22:51 Done.

tearOffAccessText =

jsAst.prettyPrint(tearOffAccessExpression, compiler).getText();

tearOffGlobalObjectName = tearOffGlobalObject =