Add canned presubmit check for GN formatting

Add canned presubmit check for GN formatting

Requires https://codereview.chromium.org/779883002/ to be landed/rolled before it's useful.

R=dpranke@chromium.org
BUG=348474
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=293269

[Dirk Pranke, 2014-12-04 21:42:01]

lgtm

[scottmg, 2014-12-04 22:15:54]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2014-12-04 22:16:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/779513005/1

[commit-bot: I haz the power, 2014-12-04 22:18:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-04 22:18:30]

Presubmit check for 779513005-1 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
Pylint (110 files) (59.33s) failed
/b/depot_tools/third_party/logilab/astroid/modutils.py:520: UserWarning: Module
six was already imported from /b/depot_tools/third_party/six/__init__.py, but
/usr/local/lib/python2.7/dist-packages is being added to sys.path
  import pkg_resources
Problem importing module .svn: No module named .svn
Problem importing module .svn: No module named .svn
************* Module fix_encoding
E:232, 0: Slice index is not an int, None, or instance with __index__
(invalid-slice-index)
************* Module gclient_scm
E:301,18: No value for argument 'print_func' in constructor call
(no-value-for-parameter)
E:1191,18: No value for argument 'print_func' in constructor call
(no-value-for-parameter)


post-dcommit-hook-test.sh failed
Command
/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/post-dcommit-hook-test.sh
returned non-zero exit status 1 in
/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests
Setting up test SVN repo...
Setting up test git-svn repo...
TESTING: dcommitted code
Using 50% similarity for rename/copy detection. Override with --similarity.
Description:
dcommit
TESTING: post-cl-dcommit hook executed
FAILURE: post-cl-dcommit hook executed


Presubmit checks took 95.1s to calculate.

[scottmg, 2014-12-04 22:30:49]

On 2014/12/04 22:18:30, I haz the power (commit-bot) wrote:
> Presubmit check for 779513005-1 failed and returned exit status 1.
> 
> Running presubmit commit checks ...
> Checking out rietveld...
> Running save-description-on-failure.sh
> Running push-basic.sh
> Running upstream.sh
> Running submit-from-new-dir.sh
> Running abandon.sh
> Running submodule-merge-test.sh
> Running upload-local-tracking-branch.sh
> Running hooks.sh
> Running post-dcommit-hook-test.sh
> Running upload-stale.sh
> Running patch.sh
> Running basic.sh
> 
> ** Presubmit ERRORS **
> Pylint (110 files) (59.33s) failed
> /b/depot_tools/third_party/logilab/astroid/modutils.py:520: UserWarning:
Module
> six was already imported from /b/depot_tools/third_party/six/__init__.py, but
> /usr/local/lib/python2.7/dist-packages is being added to sys.path
>   import pkg_resources
> Problem importing module .svn: No module named .svn
> Problem importing module .svn: No module named .svn
> ************* Module fix_encoding
> E:232, 0: Slice index is not an int, None, or instance with __index__
> (invalid-slice-index)
> ************* Module gclient_scm
> E:301,18: No value for argument 'print_func' in constructor call
> (no-value-for-parameter)
> E:1191,18: No value for argument 'print_func' in constructor call
> (no-value-for-parameter)
> 
> 
> post-dcommit-hook-test.sh failed
> Command
>
/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/post-dcommit-hook-test.sh
> returned non-zero exit status 1 in
> /b/infra_internal/commit_queue/workdir/tools/depot_tools/tests
> Setting up test SVN repo...
> Setting up test git-svn repo...
> TESTING: dcommitted code
> Using 50% similarity for rename/copy detection. Override with --similarity.
> Description:
> dcommit
> TESTING: post-cl-dcommit hook executed
> FAILURE: post-cl-dcommit hook executed
> 
> 
> Presubmit checks took 95.1s to calculate.

I guess this is the pylint update from a while back?

[Dirk Pranke, 2014-12-04 22:37:35]

On 2014/12/04 22:30:49, scottmg wrote:
> I guess this is the pylint update from a while back?

Yeah, might be. Not sure.

[scottmg, 2014-12-05 17:24:50]

Committed patchset #1 (id:1) manually as 293269.