Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 779883002: gn format: Add --dry-run flag for PRESUBMIT (Closed)

Created:
6 years ago by scottmg
Modified:
6 years ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

gn format: Add --dry-run flag for PRESUBMIT `gn format --dry-run some/BUILD.gn` sets exit code to 0 for "success, unchanged", 1 for "failure", and 2 for "success but different than on disk". This is to be able to add a PRESUBMIT.py check in the future and matches the behaviour of the same-named flag for git cl format. See also https://codereview.chromium.org/779513005/. R=brettw@chromium.org BUG=348474 Committed: https://crrev.com/f5d95bf7fb5ee07c82e62cb573af67b195284bc3 Cr-Commit-Position: refs/heads/master@{#306940}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M tools/gn/command_format.cc View 5 chunks +21 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
scottmg
6 years ago (2014-12-04 07:10:24 UTC) #1
brettw
lgtm
6 years ago (2014-12-04 23:51:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/779883002/1
6 years ago (2014-12-05 00:02:44 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-05 00:05:10 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-05 00:06:32 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f5d95bf7fb5ee07c82e62cb573af67b195284bc3
Cr-Commit-Position: refs/heads/master@{#306940}

Powered by Google App Engine
This is Rietveld 408576698