Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Side by Side Diff: tests/presubmit_unittest.py

Issue 779513005: Add canned presubmit check for GN formatting (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « presubmit_canned_checks.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """Unit tests for presubmit_support.py and presubmit_canned_checks.py.""" 6 """Unit tests for presubmit_support.py and presubmit_canned_checks.py."""
7 7
8 # pylint: disable=E1101,E1103 8 # pylint: disable=E1101,E1103
9 9
10 import functools 10 import functools
(...skipping 1860 matching lines...) Expand 10 before | Expand all | Expand 10 after
1871 'CheckChangeHasTestField', 1871 'CheckChangeHasTestField',
1872 'CheckChangeLintsClean', 1872 'CheckChangeLintsClean',
1873 'CheckChangeSvnEolStyle', 1873 'CheckChangeSvnEolStyle',
1874 'CheckChangeWasUploaded', 1874 'CheckChangeWasUploaded',
1875 'CheckDoNotSubmit', 1875 'CheckDoNotSubmit',
1876 'CheckDoNotSubmitInDescription', 'CheckDoNotSubmitInFiles', 1876 'CheckDoNotSubmitInDescription', 'CheckDoNotSubmitInFiles',
1877 'CheckLongLines', 'CheckTreeIsOpen', 'PanProjectChecks', 1877 'CheckLongLines', 'CheckTreeIsOpen', 'PanProjectChecks',
1878 'CheckLicense', 1878 'CheckLicense',
1879 'CheckOwners', 1879 'CheckOwners',
1880 'CheckPatchFormatted', 1880 'CheckPatchFormatted',
1881 'CheckGNFormatted',
1881 'CheckRietveldTryJobExecution', 1882 'CheckRietveldTryJobExecution',
1882 'CheckSingletonInHeaders', 1883 'CheckSingletonInHeaders',
1883 'CheckSvnModifiedDirectories', 1884 'CheckSvnModifiedDirectories',
1884 'CheckSvnForCommonMimeTypes', 'CheckSvnProperty', 1885 'CheckSvnForCommonMimeTypes', 'CheckSvnProperty',
1885 'RunPythonUnitTests', 'RunPylint', 1886 'RunPythonUnitTests', 'RunPylint',
1886 'RunUnitTests', 'RunUnitTestsInDirectory', 1887 'RunUnitTests', 'RunUnitTestsInDirectory',
1887 'GetPythonUnitTests', 'GetPylint', 1888 'GetPythonUnitTests', 'GetPylint',
1888 'GetUnitTests', 'GetUnitTestsInDirectory', 'GetUnitTestsRecursively', 1889 'GetUnitTests', 'GetUnitTestsInDirectory', 'GetUnitTestsRecursively',
1889 ] 1890 ]
1890 # If this test fails, you should add the relevant test. 1891 # If this test fails, you should add the relevant test.
(...skipping 1028 matching lines...) Expand 10 before | Expand all | Expand 10 after
2919 owners_check=False) 2920 owners_check=False)
2920 self.assertEqual(1, len(results)) 2921 self.assertEqual(1, len(results))
2921 self.assertEqual( 2922 self.assertEqual(
2922 'Found line ending with white spaces in:', results[0]._message) 2923 'Found line ending with white spaces in:', results[0]._message)
2923 self.checkstdout('') 2924 self.checkstdout('')
2924 2925
2925 2926
2926 if __name__ == '__main__': 2927 if __name__ == '__main__':
2927 import unittest 2928 import unittest
2928 unittest.main() 2929 unittest.main()
OLDNEW
« no previous file with comments | « presubmit_canned_checks.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698