Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 778533002: Fix language spinners in translate infobar. (Closed)

Created:
6 years ago by newt (away)
Modified:
6 years ago
Reviewers:
Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix language spinners in translate infobar. These spinners were no longer clickable as a side-effect of this CL (https://codereview.chromium.org/657893005) which make the TextViews inside the spinners clickable. As a result, the Spinner never received click events. Also, the spinner dropdown arrow was missing on pre-L devices because we were creating the Spinner using "new Spinner()" instead of inflating it from a resource. This is a no-no when using the AppCompat theme. BUG=435491 Committed: https://crrev.com/40fe0302f88370217badc36e8a652d2b5543b631 Cr-Commit-Position: refs/heads/master@{#306522}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -4 lines) Patch
A chrome/android/java/res/layout/spinner.xml View 1 chunk +13 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateLanguagePanel.java View 3 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
newt (away)
PTAL
6 years ago (2014-12-03 00:49:29 UTC) #2
Ted C
lgtm
6 years ago (2014-12-03 00:54:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/778533002/1
6 years ago (2014-12-03 01:03:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-03 01:49:17 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-03 01:50:08 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/40fe0302f88370217badc36e8a652d2b5543b631
Cr-Commit-Position: refs/heads/master@{#306522}

Powered by Google App Engine
This is Rietveld 408576698