Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(892)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateLanguagePanel.java

Issue 778533002: Fix language spinners in translate infobar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/res/layout/spinner.xml ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateLanguagePanel.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateLanguagePanel.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateLanguagePanel.java
index fb48247102ca0198dca1ce073ea676f128c772ba..77e8cb722eafdd69237d203dc2596153c12e8bc6 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateLanguagePanel.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateLanguagePanel.java
@@ -9,6 +9,7 @@ import android.graphics.Color;
import android.text.SpannableString;
import android.text.TextUtils;
import android.text.style.ForegroundColorSpan;
+import android.util.TypedValue;
import android.view.LayoutInflater;
import android.view.View;
import android.view.ViewGroup;
@@ -103,8 +104,9 @@ public class TranslateLanguagePanel
mTargetAdapter.measureWidthRequiredForView();
// Create the spinners.
- mSourceSpinner = new Spinner(context);
- mTargetSpinner = new Spinner(context);
+ LayoutInflater inflater = LayoutInflater.from(context);
+ mSourceSpinner = (Spinner) inflater.inflate(R.layout.spinner, null);
+ mTargetSpinner = (Spinner) inflater.inflate(R.layout.spinner, null);
mSourceSpinner.setOnItemSelectedListener(this);
mTargetSpinner.setOnItemSelectedListener(this);
mSourceSpinner.setAdapter(mSourceAdapter);
@@ -234,8 +236,9 @@ public class TranslateLanguagePanel
public View getView(int position, View convertView, ViewGroup parent) {
TextView result;
if (!(convertView instanceof TextView)) {
- result = (TextView) LayoutInflater.from(getContext()).inflate(
- R.layout.infobar_text, null);
+ result = new TextView(getContext());
+ result.setTextSize(TypedValue.COMPLEX_UNIT_PX,
+ getContext().getResources().getDimension(R.dimen.infobar_text_size));
} else {
result = (TextView) convertView;
}
« no previous file with comments | « chrome/android/java/res/layout/spinner.xml ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698