Add class to make text views with clickable spans accessible.

Add class to make text views with clickable spans accessible.

This will be followed with a Clank change to use this class everywhere
we're using ClickableSpans.

BUG=390226, 418989
Committed: https://crrev.com/4560b4a302e5f26e14cbe10597eaa1a9f2db5990
Cr-Commit-Position: refs/heads/master@{#300987}

[dmazzoni, 2014-10-23 17:59:42]

dmazzoni@chromium.org changed reviewers:
+ newt@chromium.org

[newt (away), 2014-10-23 18:27:21]

I like this!

lgtm after style nit

https://codereview.chromium.org/657893005/diff/1/chrome/android/java/src/org/...
File
chrome/android/java/src/org/chromium/chrome/browser/util/TextViewWithClickableSpans.java
(right):

https://codereview.chromium.org/657893005/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/util/TextViewWithClickableSpans.java:55:
if (!(text instanceof SpannableString))
nit: curly braces around all the if-else statements

[dmazzoni, 2014-10-23 20:11:17]

dmazzoni@chromium.org changed reviewers:
+ dtrainor@chromium.org

[dmazzoni, 2014-10-23 20:11:18]

Done!

+dtrainor for owners review

[newt (away), 2014-10-23 20:42:27]

Actually, could you move this file to the ui/ folder, since this could
conceivably be needed in UI widget?

[dmazzoni, 2014-10-23 20:45:41]

On 2014/10/23 20:42:27, newt wrote:
> Actually, could you move this file to the ui/ folder, since this could
> conceivably be needed in UI widget?

Which ui/ folder?

[newt (away), 2014-10-23 20:46:04]

On 2014/10/23 20:42:27, newt wrote:
> Actually, could you move this file to the ui/ folder, since this could
> conceivably be needed in UI widget?

org.chromium.ui.widget (which doesn't exist yet) seems like a good package for
this.

[newt (away), 2014-10-23 20:46:47]

On 2014/10/23 20:46:04, newt wrote:
> On 2014/10/23 20:42:27, newt wrote:
> > Actually, could you move this file to the ui/ folder, since this could
> > conceivably be needed in UI widget?
> 
> org.chromium.ui.widget (which doesn't exist yet) seems like a good package for
> this.

src/ui/android/java/src/org/chromium/ui/widget

[dmazzoni, 2014-10-23 21:01:44]

Got it, done!

Thanks for being specific - I didn't even realize there was android code
underneath the top-level ui/ directory. :)

[David Trainor- moved to gerrit, 2014-10-23 22:03:04]

lgtm

https://codereview.chromium.org/657893005/diff/40001/ui/android/java/src/org/...
File ui/android/java/src/org/chromium/ui/widget/TextViewWithClickableSpans.java
(right):

https://codereview.chromium.org/657893005/diff/40001/ui/android/java/src/org/...
ui/android/java/src/org/chromium/ui/widget/TextViewWithClickableSpans.java:86:
public boolean onMenuItemClick(MenuItem menuItem) {
@Override?

[newt (away), 2014-10-23 22:10:07]

lgtm

[dmazzoni, 2014-10-23 22:11:23]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2014-10-23 22:12:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/657893005/60001

[commit-bot: I haz the power, 2014-10-23 23:43:39]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-10-23 23:44:33]

Patchset 4 (id:??) landed as
https://crrev.com/4560b4a302e5f26e14cbe10597eaa1a9f2db5990
Cr-Commit-Position: refs/heads/master@{#300987}