Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(19)

Issue 778483002: Switch nacl-clang back to gas in SCons (Closed)

Created:
4 years, 10 months ago by Derek Schuff
Modified:
4 years, 10 months ago
CC:
native-client-reviews_googlegroups.com
Project:
nacl
Visibility:
Public.

Description

Switch nacl-clang back to gas in SCons Also re-enable nacl_clang tests which were disabled because of assembler issues. R=jvoung@chromium.org BUG= https://code.google.com/p/nativeclient/issues/detail?id=3966 BUG= https://code.google.com/p/nativeclient/issues/detail?id=3969 Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=14164

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -30 lines) Patch
M site_scons/site_tools/naclsdk.py View 2 chunks +1 line, -7 lines 0 comments Download
M tests/exception_test/nacl.scons View 1 chunk +1 line, -3 lines 0 comments Download
M tests/signal_handler_single_step/nacl.scons View 1 chunk +0 lines, -7 lines 0 comments Download
M tests/thread_suspension/nacl.scons View 1 chunk +1 line, -7 lines 0 comments Download
M tests/trusted_crash/osx_crash_forwarding/nacl.scons View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Derek Schuff
4 years, 10 months ago (2014-12-02 22:41:35 UTC) #1
jvoung (off chromium)
lgtm
4 years, 10 months ago (2014-12-02 23:50:23 UTC) #2
Derek Schuff
4 years, 10 months ago (2014-12-03 00:00:44 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 14164 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698