Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Side by Side Diff: tests/thread_suspension/nacl.scons

Issue 778483002: Switch nacl-clang back to gas in SCons (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 # -*- python -*- 1 # -*- python -*-
2 # Copyright 2012 The Native Client Authors. All rights reserved. 2 # Copyright 2012 The Native Client Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 Import('env') 6 Import('env')
7 7
8 # suspend_test_guest.nexe fails to link when Valgrind is enabled 8 # suspend_test_guest.nexe fails to link when Valgrind is enabled
9 # because of a problem with the TLS ".tbss" section. 9 # because of a problem with the TLS ".tbss" section.
10 if env.IsRunningUnderValgrind(): 10 if env.IsRunningUnderValgrind():
(...skipping 13 matching lines...) Expand all
24 test_host = trusted_env.ComponentProgram( 24 test_host = trusted_env.ComponentProgram(
25 'suspend_test_host', ['suspend_test_host.c'], 25 'suspend_test_host', ['suspend_test_host.c'],
26 EXTRA_LIBS=['sel', 'test_common']) 26 EXTRA_LIBS=['sel', 'test_common'])
27 27
28 node = env.CommandTest('thread_suspension_test.out', 28 node = env.CommandTest('thread_suspension_test.out',
29 env.AddBootstrap(test_host, [test_guest]), 29 env.AddBootstrap(test_host, [test_guest]),
30 size='large') 30 size='large')
31 31
32 # This test is flaky on mac10.7-newlib-dbg-asan. 32 # This test is flaky on mac10.7-newlib-dbg-asan.
33 # See https://code.google.com/p/nativeclient/issues/detail?id=3906 33 # See https://code.google.com/p/nativeclient/issues/detail?id=3906
34 # nacl-clang's integrated assembler expands "naclcall" to a sequence which
35 # separates the push of the return address from the jump, and so breaks the
36 # test's expectations for the stack pointer.
37 # TODO(dschuff): re-enable this test after we switch to gas with nacl-clang
38 # https://code.google.com/p/nativeclient/issues/detail?id=3966
39 is_broken= (not env.Bit('nacl_static_link') or 34 is_broken= (not env.Bit('nacl_static_link') or
40 (env.Bit('asan') and env.Bit('host_mac')) or 35 (env.Bit('asan') and env.Bit('host_mac')))
41 env.Bit('nacl_clang'))
42 36
43 env.AddNodeToTestSuite(node, ['small_tests', 'nonpexe_tests'], 37 env.AddNodeToTestSuite(node, ['small_tests', 'nonpexe_tests'],
44 'run_thread_suspension_test', is_broken=is_broken) 38 'run_thread_suspension_test', is_broken=is_broken)
OLDNEW
« no previous file with comments | « tests/signal_handler_single_step/nacl.scons ('k') | tests/trusted_crash/osx_crash_forwarding/nacl.scons » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698