Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: tests/thread_suspension/nacl.scons

Issue 778483002: Switch nacl-clang back to gas in SCons (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/signal_handler_single_step/nacl.scons ('k') | tests/trusted_crash/osx_crash_forwarding/nacl.scons » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/thread_suspension/nacl.scons
diff --git a/tests/thread_suspension/nacl.scons b/tests/thread_suspension/nacl.scons
index 30db1955770da69246ece7306f4f777f927ec858..0fa9cf1f70cd0ddcdacb2e84375b28f5cfeddc14 100644
--- a/tests/thread_suspension/nacl.scons
+++ b/tests/thread_suspension/nacl.scons
@@ -31,14 +31,8 @@ node = env.CommandTest('thread_suspension_test.out',
# This test is flaky on mac10.7-newlib-dbg-asan.
# See https://code.google.com/p/nativeclient/issues/detail?id=3906
-# nacl-clang's integrated assembler expands "naclcall" to a sequence which
-# separates the push of the return address from the jump, and so breaks the
-# test's expectations for the stack pointer.
-# TODO(dschuff): re-enable this test after we switch to gas with nacl-clang
-# https://code.google.com/p/nativeclient/issues/detail?id=3966
is_broken= (not env.Bit('nacl_static_link') or
- (env.Bit('asan') and env.Bit('host_mac')) or
- env.Bit('nacl_clang'))
+ (env.Bit('asan') and env.Bit('host_mac')))
env.AddNodeToTestSuite(node, ['small_tests', 'nonpexe_tests'],
'run_thread_suspension_test', is_broken=is_broken)
« no previous file with comments | « tests/signal_handler_single_step/nacl.scons ('k') | tests/trusted_crash/osx_crash_forwarding/nacl.scons » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698