Bind Window focus ability to the ExecutionContext instead of the process.

Bind Window focus ability to the ExecutionContext instead of the process.

WindowFocusAllowedIndicator is using a static variable that allows
the entire process to focus a window. In addition, it is entirely
stack based which prevents asynchronous methods to use it properly.

By binding the window focus ability to the ExecutionContext,
we can allow asynchronous methods but also, reduces the chances
of unrelated scripts to focus windows when they should not be
able to. Those two concerns are slightly related because an
ExecutionContext will now be able to focus a window for a
long period of time, thus, we do not want other ExecutionContext
to be able to do that in the meantime.

This is part of a three-sided CL:
Part 1: <this>
Part 2: https://codereview.chromium.org/786403003
Part 3: https://codereview.chromium.org/722423004

BUG=440740
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186849

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187285

[mlamouri (slow - plz ping), 2014-12-09 18:21:25]

mlamouri@chromium.org changed reviewers:
+ jochen@chromium.org

[mlamouri (slow - plz ping), 2014-12-09 18:21:26]

Jochen, can you have a look?

I wasn't able to test this more strongly in LayoutTests because
notificationclick is not actually implemented yet and we do not bind any
Internals to workers.

I guess we will be able to test this more when notificationclick will be ready
and using it.

[mlamouri (slow - plz ping), 2014-12-09 18:22:08]

mlamouri@chromium.org changed reviewers:
+ mkwst@chromium.org

[mlamouri (slow - plz ping), 2014-12-09 18:22:09]

+mkwst@, if you want to have a look.

[mlamouri (slow - plz ping), 2014-12-10 12:32:10]

FWIW, parts 2 and 3 are uploaded.

[jochen (gone - plz use gerrit), 2014-12-10 14:00:55]

lgtm

https://codereview.chromium.org/777483004/diff/20001/public/web/WebScopedWind...
File public/web/WebScopedWindowFocusAllowedIndicator.h (right):

https://codereview.chromium.org/777483004/diff/20001/public/web/WebScopedWind...
public/web/WebScopedWindowFocusAllowedIndicator.h:45:
WebScopedWindowFocusAllowedIndicator() { initialize(); }
this constructor is now deprecated, right? can you add a comment?

[jochen (gone - plz use gerrit), 2014-12-10 14:00:55]

lgtm

https://codereview.chromium.org/777483004/diff/20001/public/web/WebScopedWind...
File public/web/WebScopedWindowFocusAllowedIndicator.h (right):

https://codereview.chromium.org/777483004/diff/20001/public/web/WebScopedWind...
public/web/WebScopedWindowFocusAllowedIndicator.h:45:
WebScopedWindowFocusAllowedIndicator() { initialize(); }
this constructor is now deprecated, right? can you add a comment?

[mlamouri (slow - plz ping), 2014-12-10 14:08:11]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2014-12-10 14:08:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/777483004/40001

[commit-bot: I haz the power, 2014-12-10 15:30:07]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186849

[amineer_google, 2014-12-15 22:57:47]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/803253003/ by amineer@google.com.

The reason for reverting is: Crashing, see bug 441968.

[mlamouri (slow - plz ping), 2014-12-16 11:15:26]

On 2014/12/15 22:57:47, amineer wrote:
> A revert of this CL (patchset #3 id:40001) has been created in
> https://codereview.chromium.org/803253003/ by mailto:amineer@google.com.
> 
> The reason for reverting is: Crashing, see bug 441968.

I see no valid reason why this CL has been reverted. The part 2 of the
multi-sided CL might cause the crash but this has notihng to do with it.

I will re-open and re-land.

[mlamouri (slow - plz ping), 2014-12-16 11:15:37]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2014-12-16 11:16:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/777483004/40001

[commit-bot: I haz the power, 2014-12-16 11:16:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-16 11:16:14]

Failed to apply patch for Source/core/dom/ExecutionContext.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/dom/ExecutionContext.cpp
  Hunk #2 FAILED at 74.
  Hunk #3 succeeded at 273 (offset 1 line).
  1 out of 3 hunks FAILED -- saving rejects to file
Source/core/dom/ExecutionContext.cpp.rej

Patch:       Source/core/dom/ExecutionContext.cpp
Index: Source/core/dom/ExecutionContext.cpp
diff --git a/Source/core/dom/ExecutionContext.cpp
b/Source/core/dom/ExecutionContext.cpp
index
887f2e70ee4a597c20c5fe8596055cf0084bb9fb..240a99d3fe3675b87db24d68d3a251f68b9a4435
100644
--- a/Source/core/dom/ExecutionContext.cpp
+++ b/Source/core/dom/ExecutionContext.cpp
@@ -36,6 +36,7 @@
 #include "core/html/PublicURLManager.h"
 #include "core/inspector/InspectorInstrumentation.h"
 #include "core/inspector/ScriptCallStack.h"
+#include "core/page/WindowFocusAllowedIndicator.h"
 #include "core/workers/WorkerGlobalScope.h"
 #include "core/workers/WorkerThread.h"
 #include "wtf/MainThread.h"
@@ -73,6 +74,7 @@ ExecutionContext::ExecutionContext()
     , m_inDispatchErrorEvent(false)
     , m_activeDOMObjectsAreSuspended(false)
     , m_activeDOMObjectsAreStopped(false)
+    , m_windowFocusTokens(0)
 {
 }
 
@@ -271,6 +273,26 @@ void ExecutionContext::enforceSandboxFlags(SandboxFlags
mask)
     }
 }
 
+void ExecutionContext::allowWindowFocus()
+{
+    ++m_windowFocusTokens;
+}
+
+void ExecutionContext::consumeWindowFocus()
+{
+    if (m_windowFocusTokens == 0)
+        return;
+    --m_windowFocusTokens;
+}
+
+bool ExecutionContext::isWindowFocusAllowed() const
+{
+    // FIXME: WindowFocusAllowedIndicator::windowFocusAllowed() is temporary,
+    // it will be removed as soon as WebScopedWindowFocusAllowedIndicator will
+    // be updated to not use WindowFocusAllowedIndicator.
+    return m_windowFocusTokens > 0 ||
WindowFocusAllowedIndicator::windowFocusAllowed();
+}
+
 void ExecutionContext::trace(Visitor* visitor)
 {
 #if ENABLE(OILPAN)

[mlamouri (slow - plz ping), 2014-12-16 11:37:45]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2014-12-16 11:38:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/777483004/60001

[commit-bot: I haz the power, 2014-12-16 11:38:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-16 11:38:26]

Failed to apply patch for Source/core/dom/ExecutionContext.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/dom/ExecutionContext.cpp
  Hunk #2 FAILED at 74.
  Hunk #3 succeeded at 273 (offset 1 line).
  1 out of 3 hunks FAILED -- saving rejects to file
Source/core/dom/ExecutionContext.cpp.rej

Patch:       Source/core/dom/ExecutionContext.cpp
Index: Source/core/dom/ExecutionContext.cpp
diff --git a/Source/core/dom/ExecutionContext.cpp
b/Source/core/dom/ExecutionContext.cpp
index
887f2e70ee4a597c20c5fe8596055cf0084bb9fb..240a99d3fe3675b87db24d68d3a251f68b9a4435
100644
--- a/Source/core/dom/ExecutionContext.cpp
+++ b/Source/core/dom/ExecutionContext.cpp
@@ -36,6 +36,7 @@
 #include "core/html/PublicURLManager.h"
 #include "core/inspector/InspectorInstrumentation.h"
 #include "core/inspector/ScriptCallStack.h"
+#include "core/page/WindowFocusAllowedIndicator.h"
 #include "core/workers/WorkerGlobalScope.h"
 #include "core/workers/WorkerThread.h"
 #include "wtf/MainThread.h"
@@ -73,6 +74,7 @@ ExecutionContext::ExecutionContext()
     , m_inDispatchErrorEvent(false)
     , m_activeDOMObjectsAreSuspended(false)
     , m_activeDOMObjectsAreStopped(false)
+    , m_windowFocusTokens(0)
 {
 }
 
@@ -271,6 +273,26 @@ void ExecutionContext::enforceSandboxFlags(SandboxFlags
mask)
     }
 }
 
+void ExecutionContext::allowWindowFocus()
+{
+    ++m_windowFocusTokens;
+}
+
+void ExecutionContext::consumeWindowFocus()
+{
+    if (m_windowFocusTokens == 0)
+        return;
+    --m_windowFocusTokens;
+}
+
+bool ExecutionContext::isWindowFocusAllowed() const
+{
+    // FIXME: WindowFocusAllowedIndicator::windowFocusAllowed() is temporary,
+    // it will be removed as soon as WebScopedWindowFocusAllowedIndicator will
+    // be updated to not use WindowFocusAllowedIndicator.
+    return m_windowFocusTokens > 0 ||
WindowFocusAllowedIndicator::windowFocusAllowed();
+}
+
 void ExecutionContext::trace(Visitor* visitor)
 {
 #if ENABLE(OILPAN)

[mlamouri (slow - plz ping), 2014-12-16 15:13:05]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2014-12-16 15:13:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/777483004/60001

[commit-bot: I haz the power, 2014-12-16 15:13:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-16 15:13:50]

Failed to apply patch for Source/core/dom/ExecutionContext.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/dom/ExecutionContext.cpp
  Hunk #2 FAILED at 74.
  Hunk #3 succeeded at 273 (offset 1 line).
  1 out of 3 hunks FAILED -- saving rejects to file
Source/core/dom/ExecutionContext.cpp.rej

Patch:       Source/core/dom/ExecutionContext.cpp
Index: Source/core/dom/ExecutionContext.cpp
diff --git a/Source/core/dom/ExecutionContext.cpp
b/Source/core/dom/ExecutionContext.cpp
index
887f2e70ee4a597c20c5fe8596055cf0084bb9fb..240a99d3fe3675b87db24d68d3a251f68b9a4435
100644
--- a/Source/core/dom/ExecutionContext.cpp
+++ b/Source/core/dom/ExecutionContext.cpp
@@ -36,6 +36,7 @@
 #include "core/html/PublicURLManager.h"
 #include "core/inspector/InspectorInstrumentation.h"
 #include "core/inspector/ScriptCallStack.h"
+#include "core/page/WindowFocusAllowedIndicator.h"
 #include "core/workers/WorkerGlobalScope.h"
 #include "core/workers/WorkerThread.h"
 #include "wtf/MainThread.h"
@@ -73,6 +74,7 @@ ExecutionContext::ExecutionContext()
     , m_inDispatchErrorEvent(false)
     , m_activeDOMObjectsAreSuspended(false)
     , m_activeDOMObjectsAreStopped(false)
+    , m_windowFocusTokens(0)
 {
 }
 
@@ -271,6 +273,26 @@ void ExecutionContext::enforceSandboxFlags(SandboxFlags
mask)
     }
 }
 
+void ExecutionContext::allowWindowFocus()
+{
+    ++m_windowFocusTokens;
+}
+
+void ExecutionContext::consumeWindowFocus()
+{
+    if (m_windowFocusTokens == 0)
+        return;
+    --m_windowFocusTokens;
+}
+
+bool ExecutionContext::isWindowFocusAllowed() const
+{
+    // FIXME: WindowFocusAllowedIndicator::windowFocusAllowed() is temporary,
+    // it will be removed as soon as WebScopedWindowFocusAllowedIndicator will
+    // be updated to not use WindowFocusAllowedIndicator.
+    return m_windowFocusTokens > 0 ||
WindowFocusAllowedIndicator::windowFocusAllowed();
+}
+
 void ExecutionContext::trace(Visitor* visitor)
 {
 #if ENABLE(OILPAN)

[mlamouri (slow - plz ping), 2014-12-16 15:28:02]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2014-12-16 15:28:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/777483004/80001

[commit-bot: I haz the power, 2014-12-16 16:18:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-16 16:18:58]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/42078)

[mlamouri (slow - plz ping), 2014-12-16 16:19:15]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2014-12-16 16:19:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/777483004/80001

[commit-bot: I haz the power, 2014-12-16 16:20:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-16 16:20:32]

Failed to apply patch for Source/modules/notifications/Notification.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/modules/notifications/Notification.cpp
  Hunk #1 FAILED at 33.
  Hunk #2 succeeded at 163 (offset 7 lines).
  1 out of 2 hunks FAILED -- saving rejects to file
Source/modules/notifications/Notification.cpp.rej

Patch:       Source/modules/notifications/Notification.cpp
Index: Source/modules/notifications/Notification.cpp
diff --git a/Source/modules/notifications/Notification.cpp
b/Source/modules/notifications/Notification.cpp
index
51d0a27fd02f575102b0366fd09e2ae9c1d81511..73b2c1afb88e0b31a68a8da2693747559bf4b111
100644
--- a/Source/modules/notifications/Notification.cpp
+++ b/Source/modules/notifications/Notification.cpp
@@ -33,9 +33,9 @@
 
 #include "bindings/core/v8/ScriptWrappable.h"
 #include "core/dom/Document.h"
+#include "core/dom/ScopedWindowFocusAllowedIndicator.h"
 #include "core/events/Event.h"
 #include "core/frame/UseCounter.h"
-#include "core/page/WindowFocusAllowedIndicator.h"
 #include "modules/notifications/NotificationOptions.h"
 #include "modules/notifications/NotificationPermissionClient.h"
 #include "public/platform/Platform.h"
@@ -156,7 +156,7 @@ void Notification::dispatchShowEvent()
 void Notification::dispatchClickEvent()
 {
     UserGestureIndicator gestureIndicator(DefinitelyProcessingNewUserGesture);
-    WindowFocusAllowedIndicator windowFocusAllowed;
+    ScopedWindowFocusAllowedIndicator windowFocusAllowed(executionContext());
     dispatchEvent(Event::create(EventTypeNames::click));
 }

[mlamouri (slow - plz ping), 2014-12-16 17:47:00]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2014-12-16 17:47:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/777483004/100001

[commit-bot: I haz the power, 2014-12-16 19:17:47]

Committed patchset #6 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187285