Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(786)

Unified Diff: content/child/webcrypto/openssl/hmac_openssl.cc

Issue 777403004: [WebCrypto] Throw syntaxError if keyUsage is empty in ImportKey (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/webcrypto/openssl/hmac_openssl.cc
diff --git a/content/child/webcrypto/openssl/hmac_openssl.cc b/content/child/webcrypto/openssl/hmac_openssl.cc
index 76f63c3236818e539f11baed09808b6cbd6fb484..20003c4776ca7afa52f99d48e9e73d9f1afba131 100644
--- a/content/child/webcrypto/openssl/hmac_openssl.cc
+++ b/content/child/webcrypto/openssl/hmac_openssl.cc
@@ -70,7 +70,7 @@ class HmacImplementation : public AlgorithmImplementation {
bool extractable,
blink::WebCryptoKeyUsageMask usages,
GenerateKeyResult* result) const override {
- Status status = CheckKeyCreationUsages(kAllKeyUsages, usages);
+ Status status = CheckKeyCreationUsages(kAllKeyUsages, usages, false);
eroman 2014/12/09 21:04:46 Same comment as earlier.
if (status.IsError())
return status;
@@ -94,7 +94,7 @@ class HmacImplementation : public AlgorithmImplementation {
switch (format) {
case blink::WebCryptoKeyFormatRaw:
case blink::WebCryptoKeyFormatJwk:
- return CheckKeyCreationUsages(kAllKeyUsages, usages);
+ return CheckKeyCreationUsages(kAllKeyUsages, usages, true);
default:
return Status::ErrorUnsupportedImportKeyFormat();
}

Powered by Google App Engine
This is Rietveld 408576698