content/child/webcrypto/status.h - Issue 777403004: [WebCrypto] Throw syntaxError if keyUsage is empty in ImportKey

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/webcrypto/status.h

Issue 777403004: [WebCrypto] Throw syntaxError if keyUsage is empty in ImportKey (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/child/webcrypto/openssl/hmac_openssl.cc ('K') | « content/child/webcrypto/openssl/rsa_key_openssl.cc ('k') | content/child/webcrypto/status.cc » ('j') | content/child/webcrypto/test/rsa_ssa_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/webcrypto/status.h

diff --git a/content/child/webcrypto/status.h b/content/child/webcrypto/status.h

index 56a14ef1463f208a397f634710ac239d660f6308..0ac69fd875d9f41ffc0e68cc3e0f0bdd2bca9cd5 100644

--- a/content/child/webcrypto/status.h

+++ b/content/child/webcrypto/status.h

@@ -223,6 +223,9 @@ class CONTENT_EXPORT Status {

// No usages were specified when creating a secret or private key.

static Status ErrorCreateKeyEmptyUsages();

+ // No usages were specified when importing a key.

+ static Status ErrorImportKeyEmptyUsages();

eroman 2014/12/09 21:04:46 Why not use ErrorCreateKeyEmptyUsages() which is a

Habib Virji 2014/12/15 18:48:55 Was keeping it different as error message, explici

// An EC key imported using SPKI/PKCS8 format had the wrong curve specified in

// the key.

static Status ErrorImportedEcKeyIncorrectCurve();