[WebCrypto] Throw syntaxError if keyUsage is empty in ImportKey

content/child/webcrypto/openssl/hmac_openssl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <openssl/hmac.h>
 
 #include "base/logging.h"
 #include "base/numerics/safe_math.h"
 #include "base/stl_util.h"
 #include "content/child/webcrypto/algorithm_implementation.h"
@@ skipping 52 matching lines @@
 }
 
 class HmacImplementation : public AlgorithmImplementation {
  public:
   HmacImplementation() {}
 
   Status GenerateKey(const blink::WebCryptoAlgorithm& algorithm,
                      bool extractable,
                      blink::WebCryptoKeyUsageMask usages,
                      GenerateKeyResult* result) const override {
-    Status status = CheckKeyCreationUsages(kAllKeyUsages, usages);
+    Status status = CheckKeyCreationUsages(kAllKeyUsages, usages, false);

[eroman, 2014/12/09 21:04:46]

Same comment as earlier.

     if (status.IsError())
       return status;
 
     const blink::WebCryptoHmacKeyGenParams* params =
         algorithm.hmacKeyGenParams();
 
     unsigned int keylen_bits = 0;
     status = GetHmacKeyGenLengthInBits(params, &keylen_bits);
     if (status.IsError())
       return status;
 
     return GenerateSecretKeyOpenSsl(blink::WebCryptoKeyAlgorithm::createHmac(
                                         params->hash().id(), keylen_bits),
                                     extractable, usages, keylen_bits / 8,
                                     result);
   }
 
   Status VerifyKeyUsagesBeforeImportKey(
       blink::WebCryptoKeyFormat format,
       blink::WebCryptoKeyUsageMask usages) const override {
     switch (format) {
       case blink::WebCryptoKeyFormatRaw:
       case blink::WebCryptoKeyFormatJwk:
-        return CheckKeyCreationUsages(kAllKeyUsages, usages);
+        return CheckKeyCreationUsages(kAllKeyUsages, usages, true);
       default:
         return Status::ErrorUnsupportedImportKeyFormat();
     }
   }
 
   Status ImportKeyRaw(const CryptoData& key_data,
                       const blink::WebCryptoAlgorithm& algorithm,
                       bool extractable,
                       blink::WebCryptoKeyUsageMask usages,
                       blink::WebCryptoKey* key) const override {
@@ skipping 106 matching lines @@
 
 }  // namespace
 
 AlgorithmImplementation* CreatePlatformHmacImplementation() {
   return new HmacImplementation;
 }
 
 }  // namespace webcrypto
 
 }  // namespace content