Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3134)

Unified Diff: chrome/browser/ui/startup/startup_browser_creator_browsertest.cc

Issue 777143003: Clean up straggler classes to use embedded signin in page in the new profiles world. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
diff --git a/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc b/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
index fdc0bbb1f15d999477b11dd4ad96a5288931a776..ba7d3b297327fc197ad20430a0571832eb63180b 100644
--- a/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
+++ b/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
@@ -508,7 +508,7 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorTest, SyncPromoNoWelcomePage) {
EXPECT_EQ(1, tab_strip->count());
if (signin::ShouldShowPromoAtStartup(browser()->profile(), true)) {
- EXPECT_EQ(signin::GetPromoURL(signin::SOURCE_START_PAGE, false),
+ EXPECT_EQ(signin::GetPromoURL(signin_metrics::SOURCE_START_PAGE, false),
tab_strip->GetWebContentsAt(0)->GetURL());
} else {
EXPECT_EQ(GURL(chrome::kChromeUINewTabURL),
@@ -534,7 +534,7 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorTest, SyncPromoWithWelcomePage) {
EXPECT_EQ(2, tab_strip->count());
if (signin::ShouldShowPromoAtStartup(browser()->profile(), true)) {
- EXPECT_EQ(signin::GetPromoURL(signin::SOURCE_START_PAGE, false),
+ EXPECT_EQ(signin::GetPromoURL(signin_metrics::SOURCE_START_PAGE, false),
tab_strip->GetWebContentsAt(0)->GetURL());
} else {
EXPECT_EQ(GURL(chrome::kChromeUINewTabURL),
@@ -567,7 +567,7 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorTest, SyncPromoWithFirstRunTabs) {
TabStripModel* tab_strip = new_browser->tab_strip_model();
if (signin::ShouldShowPromoAtStartup(browser()->profile(), true)) {
EXPECT_EQ(2, tab_strip->count());
- EXPECT_EQ(signin::GetPromoURL(signin::SOURCE_START_PAGE, false),
+ EXPECT_EQ(signin::GetPromoURL(signin_metrics::SOURCE_START_PAGE, false),
tab_strip->GetWebContentsAt(0)->GetURL());
EXPECT_EQ("title1.html",
tab_strip->GetWebContentsAt(1)->GetURL().ExtractFileName());
@@ -600,7 +600,7 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorTest,
TabStripModel* tab_strip = new_browser->tab_strip_model();
if (signin::ShouldShowPromoAtStartup(browser()->profile(), true)) {
EXPECT_EQ(3, tab_strip->count());
- EXPECT_EQ(signin::GetPromoURL(signin::SOURCE_START_PAGE, false),
+ EXPECT_EQ(signin::GetPromoURL(signin_metrics::SOURCE_START_PAGE, false),
tab_strip->GetWebContentsAt(0)->GetURL());
EXPECT_EQ("title1.html",
tab_strip->GetWebContentsAt(1)->GetURL().ExtractFileName());
@@ -1200,7 +1200,7 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest,
// Verify that the sync promo and the welcome page are shown.
TabStripModel* tab_strip = new_browser->tab_strip_model();
ASSERT_EQ(2, tab_strip->count());
- EXPECT_EQ(signin::GetPromoURL(signin::SOURCE_START_PAGE, false),
+ EXPECT_EQ(signin::GetPromoURL(signin_metrics::SOURCE_START_PAGE, false),
tab_strip->GetWebContentsAt(0)->GetURL());
EXPECT_EQ(internals::GetWelcomePageURL(),
tab_strip->GetWebContentsAt(1)->GetURL());
@@ -1242,7 +1242,7 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest,
// Verify that the first-run tab is shown and the sync promo has been added.
TabStripModel* tab_strip = new_browser->tab_strip_model();
ASSERT_EQ(2, tab_strip->count());
- EXPECT_EQ(signin::GetPromoURL(signin::SOURCE_START_PAGE, false),
+ EXPECT_EQ(signin::GetPromoURL(signin_metrics::SOURCE_START_PAGE, false),
tab_strip->GetWebContentsAt(0)->GetURL());
EXPECT_EQ("title1.html",
tab_strip->GetWebContentsAt(1)->GetURL().ExtractFileName());
@@ -1270,8 +1270,8 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest,
ASSERT_TRUE(test_server()->Start());
StartupBrowserCreator browser_creator;
browser_creator.AddFirstRunTab(test_server()->GetURL("files/title1.html"));
- browser_creator.AddFirstRunTab(signin::GetPromoURL(signin::SOURCE_START_PAGE,
- false));
+ browser_creator.AddFirstRunTab(
+ signin::GetPromoURL(signin_metrics::SOURCE_START_PAGE, false));
browser()->profile()->GetPrefs()->SetBoolean(
prefs::kSignInPromoShowOnFirstRunAllowed, true);
@@ -1292,7 +1292,7 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest,
ASSERT_EQ(2, tab_strip->count());
EXPECT_EQ("title1.html",
tab_strip->GetWebContentsAt(0)->GetURL().ExtractFileName());
- EXPECT_EQ(signin::GetPromoURL(signin::SOURCE_START_PAGE, false),
+ EXPECT_EQ(signin::GetPromoURL(signin_metrics::SOURCE_START_PAGE, false),
tab_strip->GetWebContentsAt(1)->GetURL());
}
@@ -1337,7 +1337,7 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest,
// been replaced by the sync promo.
TabStripModel* tab_strip = new_browser->tab_strip_model();
ASSERT_EQ(2, tab_strip->count());
- EXPECT_EQ(signin::GetPromoURL(signin::SOURCE_START_PAGE, false),
+ EXPECT_EQ(signin::GetPromoURL(signin_metrics::SOURCE_START_PAGE, false),
tab_strip->GetWebContentsAt(0)->GetURL());
EXPECT_EQ("title1.html",
tab_strip->GetWebContentsAt(1)->GetURL().ExtractFileName());

Powered by Google App Engine
This is Rietveld 408576698