chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm - Issue 777143003: Clean up straggler classes to use embedded signin in page in the new profiles world.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm

Issue 777143003: Clean up straggler classes to use embedded signin in page in the new profiles world. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/one_click_signin_view_controller.mm ('k') | chrome/browser/ui/startup/startup_browser_creator_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm

diff --git a/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm b/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm

index 7724f0a75b1b061a9cf8b52f892a71aa0a613c3c..cbdbc703cd1c1592f58d667de3fac489f5371169 100644

--- a/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm

+++ b/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm

@@ -1930,15 +1930,16 @@ class ActiveProfileObserverBridge : public AvatarMenuObserver,

SigninErrorController* errorController = NULL;

switch (viewMode_) {

case profiles::BUBBLE_VIEW_MODE_GAIA_SIGNIN:

- url = signin::GetPromoURL(signin::SOURCE_AVATAR_BUBBLE_SIGN_IN,

+ url = signin::GetPromoURL(signin_metrics::SOURCE_AVATAR_BUBBLE_SIGN_IN,

false /* auto_close */,

true /* is_constrained */);

messageId = IDS_PROFILES_GAIA_SIGNIN_TITLE;

break;

case profiles::BUBBLE_VIEW_MODE_GAIA_ADD_ACCOUNT:

- url = signin::GetPromoURL(signin::SOURCE_AVATAR_BUBBLE_ADD_ACCOUNT,

- false /* auto_close */,

- true /* is_constrained */);

+ url = signin::GetPromoURL(

+ signin_metrics::SOURCE_AVATAR_BUBBLE_ADD_ACCOUNT,

+ false /* auto_close */,

+ true /* is_constrained */);

messageId = IDS_PROFILES_GAIA_ADD_ACCOUNT_TITLE;

break;

case profiles::BUBBLE_VIEW_MODE_GAIA_REAUTH: