chrome/browser/ui/startup/startup_browser_creator_impl.cc - Issue 777143003: Clean up straggler classes to use embedded signin in page in the new profiles world.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/startup/startup_browser_creator_impl.cc

Issue 777143003: Clean up straggler classes to use embedded signin in page in the new profiles world. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/startup/startup_browser_creator_browsertest.cc ('k') | chrome/browser/ui/sync/one_click_signin_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/startup/startup_browser_creator_impl.cc

diff --git a/chrome/browser/ui/startup/startup_browser_creator_impl.cc b/chrome/browser/ui/startup/startup_browser_creator_impl.cc

index 79e89d0909f3aa832a7b0a82bc7ff8a91b8561fb..412187906a45081f5db463cdb01988c85ab4cc1d 100644

--- a/chrome/browser/ui/startup/startup_browser_creator_impl.cc

+++ b/chrome/browser/ui/startup/startup_browser_creator_impl.cc

@@ -887,8 +887,8 @@ void StartupBrowserCreatorImpl::AddStartupURLs(

if (signin::ShouldShowPromoAtStartup(profile_, is_first_run_)) {

signin::DidShowPromoAtStartup(profile_);

- const GURL sync_promo_url = signin::GetPromoURL(signin::SOURCE_START_PAGE,

- false);

+ const GURL sync_promo_url = signin::GetPromoURL(

+ signin_metrics::SOURCE_START_PAGE, false);

// No need to add if the sync promo is already in the startup list.

bool add_promo = true;