Clean up straggler classes to use embedded signin in page in the new profiles world.

chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/extensions/extension_installed_bubble_view.h"
 
 #include <algorithm>
 #include <string>
 
 #include "base/i18n/rtl.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/extensions/api/commands/command_service.h"
 #include "chrome/browser/extensions/extension_action.h"
 #include "chrome/browser/extensions/extension_action_manager.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/signin/signin_promo.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_window.h"
+#include "chrome/browser/ui/chrome_pages.h"
 #include "chrome/browser/ui/singleton_tabs.h"
 #include "chrome/browser/ui/sync/sync_promo_ui.h"
 #include "chrome/browser/ui/views/frame/browser_view.h"
 #include "chrome/browser/ui/views/location_bar/location_bar_view.h"
 #include "chrome/browser/ui/views/location_bar/page_action_with_badge_view.h"
 #include "chrome/browser/ui/views/tabs/tab_strip.h"
 #include "chrome/browser/ui/views/toolbar/browser_actions_container.h"
 #include "chrome/browser/ui/views/toolbar/toolbar_action_view.h"
 #include "chrome/browser/ui/views/toolbar/toolbar_view.h"
 #include "chrome/common/extensions/api/omnibox/omnibox_handler.h"
@@ skipping 50 matching lines @@
 
 }  // namespace chrome
 
 // InstalledBubbleContent is the content view which is placed in the
 // ExtensionInstalledBubbleView. It displays the install icon and explanatory
 // text about the installed extension.
 class InstalledBubbleContent : public views::View,
                                public views::ButtonListener,
                                public views::LinkListener {
  public:
   InstalledBubbleContent(Browser* browser,

[Peter Kasting, 2014/12/12 21:43:05]

Nit: While here, consider separating the implementations of these functions from
the declarations.  (See "What about code outside of headers?" in
http://dev.chromium.org/developers/coding-style/cpp-dos-and-donts .)

[noms (inactive), 2014/12/16 16:55:50]

I will do it in a followup CL and send it over for review.

                          const Extension* extension,
                          ExtensionInstalledBubble::BubbleType type,
                          const SkBitmap* icon)
       : browser_(browser),
         extension_id_(extension->id()),
         type_(type),
         flavors_(NONE),
         height_of_signin_promo_(0u),
         how_to_use_(NULL),
         sign_in_link_(NULL),
@@ skipping 133 matching lines @@
   }
 
   void ButtonPressed(views::Button* sender, const ui::Event& event) override {
     DCHECK_EQ(sender, close_button_);
     GetWidget()->Close();
   }
 
   // Implements the views::LinkListener interface.
   void LinkClicked(views::Link* source, int event_flags) override {
     GetWidget()->Close();
-    std::string configure_url;
     if (source == manage_shortcut_) {
-      configure_url = chrome::kChromeUIExtensionsURL;
+      std::string configure_url = chrome::kChromeUIExtensionsURL;
       configure_url += chrome::kExtensionConfigureCommandsSubPage;
+      chrome::NavigateParams params(chrome::GetSingletonTabNavigateParams(
+          browser_, GURL(configure_url.c_str())));

[Peter Kasting, 2014/12/12 21:43:05]

Remove .c_str() here, since GURL's constructor actually takes a std::string.

[noms (inactive), 2014/12/16 16:55:50]

Done.

+      chrome::Navigate(&params);
     } else if (source == sign_in_link_) {

[Peter Kasting, 2014/12/12 21:43:05]

Nit: While here, I might just do:

  if (source == sign_in_link_) {
    chrome::ShowBrowserSignin(...);
    return;
  }

  DCHECK_EQ(manage_shortcut_, source);
  ...

To get rid of the NOTREACHED(); return;.

[noms (inactive), 2014/12/16 16:55:50]

Done.

-      configure_url = signin::GetPromoURL(
-          signin::SOURCE_EXTENSION_INSTALL_BUBBLE, false).spec();
+      chrome::ShowBrowserSignin(browser_,
+                                signin::SOURCE_EXTENSION_INSTALL_BUBBLE);
     } else {
       NOTREACHED();
       return;
     }
-    chrome::NavigateParams params(
-        chrome::GetSingletonTabNavigateParams(
-            browser_, GURL(configure_url.c_str())));
-    chrome::Navigate(&params);
   }
 
  private:
   enum Flavors {
     NONE            = 0,
     HOW_TO_USE      = 1 << 0,
     HOW_TO_MANAGE   = 1 << 1,
     SHOW_KEYBINDING = 1 << 2,
     SIGN_IN_PROMO   = 1 << 3,
   };
@@ skipping 329 matching lines @@
   if (bubble_.extension() && bubble_.type() == bubble_.PAGE_ACTION &&
       !extensions::FeatureSwitch::extension_action_redesign()->IsEnabled()) {
     BrowserView* browser_view =
         BrowserView::GetBrowserViewForBrowser(bubble_.browser());
     browser_view->GetLocationBarView()->SetPreviewEnabledPageAction(
         extensions::ExtensionActionManager::Get(bubble_.browser()->profile())->
         GetPageAction(*bubble_.extension()),
         false);  // preview_enabled
   }
 }