tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index c4f6eaced25000b3fb4828196b19c157c4d67530..0d4f6604fbc7048c9bf98c49d56cec794421b16b 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -32236,13 +32236,20 @@ Therefore, the affected-histogram name has to have at least one dot in it.
 </histogram>
 
 <histogram name="Signin.OneClickConfirmation" enum="SigninFlowConfirmations">
-  <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
+  <owner>rogerta@chromium.org</owner>
   <summary>
     Count of the ways users interact with the confirmation dialogs of the new
     web based sign in to Chrome flow (accessed via the one click signin).
   </summary>
 </histogram>
 
+<histogram name="Signin.Reauth" enum="SigninReauthStates">
+  <owner>noms@chromium.org</owner>
+  <summary>
+    Tracks the reason for showing the reauthentication Gaia page.
+  </summary>
+</histogram>
+
 <histogram name="Signin.Reconciler.AddedToChrome">
   <obsolete>
     Deprecated 2014-09 because chrome no longer tries to reconcile from the
@@ -32316,6 +32323,14 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   </summary>
 </histogram>
 
+<histogram name="Signin.SigninSource" enum="SigninSource">
+  <owner>noms@chromium.org</owner>
+  <summary>
+    Tracks the original source that caused the avatar menu to open with a signin
+    or reauth Gaia page.
+  </summary>
+</histogram>
+
 <histogram name="Signin.SignoutProfile" enum="SigninSignoutProfile">
   <owner>mlerman@chromium.org</owner>
   <summary>Track how a profile gets signed out.</summary>
@@ -54884,6 +54899,11 @@ To add a new entry, add it with any value and run test to compute valid value.
   <int value="10" label="Undo">The sync was aborted with an undo button.</int>
 </enum>
 
+<enum name="SigninReauthStates" type="int">
+  <int value="0" label="Account mismatch"/>
+  <int value="1" label="Shown"/>

[Alexei Svitkine (slow), 2014/12/12 15:48:55]

I don't understand what this enum entry means in the context of the histogram
its associated with. Is it a normalizing factor to count all times its shown? If
so, histogram dashboard can already tell you the total of all groups, so it's
not really necessary. Unless there are cases when its shown that don't fall into
the other buckets - in which case maybe an Other bucket be here instead?

[noms (inactive), 2014/12/12 15:59:29]

I think so? I just added a histogram for it, since the code was logging it but
wasn't adding the histogram to the dashboard. Do you think I should remove this
value? It seems to be the only value that's being logged too.

[Alexei Svitkine (slow), 2014/12/12 17:53:05]

I guess you're trying to re-purpose the histogram to track more things than just
"Reauth Shown". This is OK - but then change the description of the histogram to
be clear. e.g. you can say "Tracks events related to the reauthentication Gaia
page." - that will make the "Shown" entry more clear (though maybe also rename
it to "Reauth Shown"). This would make more sense than "Shown" being the "reason
for showing the reauth page".

[noms (inactive), 2014/12/16 16:55:50]

Done.

+</enum>
+
 <enum name="SigninSignoutProfile" type="int">
   <int value="0" label="Preference changed">
     The preference or policy controlling if signin is valid has changed.
@@ -54909,6 +54929,22 @@ To add a new entry, add it with any value and run test to compute valid value.
   </int>
 </enum>
 
+<enum name="SigninSource" type="int">
+  <int value="0" label="Start page"/>
+  <int value="1" label="NTP Link"/>
+  <int value="2" label="Menu"/>
+  <int value="3" label="Settings"/>
+  <int value="4" label="Extension install bubble"/>
+  <int value="5" label="App launcher"/>
+  <int value="6" label="Apps page link"/>
+  <int value="7" label="Bookmark bubble"/>
+  <int value="8" label="Avatar bubble sign in"/>
+  <int value="9" label="Avatar bubble add account"/>
+  <int value="10" label="Devices page"/>
+  <int value="11" label="Reauth"/>
+  <int value="12" label="Unknown"/>
+</enum>
+
 <enum name="SimpleCache.EntryCreatedAndStream2Omitted" type="int">
   <int value="0" label="Stream 2 file was present"/>
   <int value="1" label="Empty stream 2 file was omitted"/>