The Apps ntp page should not display an avatar menu when clicking on the username.

The Apps ntp page should not display an avatar menu when clicking on the username.

The menu displayed is a Chrome native menu, and it's being displayed inside the
content area, which is pretty wrong. Also, it's the wrong, old profiles UI.

BUG=323977
Committed: https://crrev.com/9b525b712fffe4a445e38fec56ac72b607242ac3
Cr-Commit-Position: refs/heads/master@{#308349}

[noms (inactive), 2014-12-05 15:17:03]

noms@chromium.org changed reviewers:
+ rogerta@chromium.org

[noms (inactive), 2014-12-05 15:17:03]

noms@chromium.org changed reviewers:
+ rogerta@chromium.org

[noms (inactive), 2014-12-05 15:17:03]

Roger, would you mind taking a look at this please, before I send it for owners
review? Thanks.

[noms (inactive), 2014-12-05 15:17:04]

Roger, would you mind taking a look at this please, before I send it for owners
review? Thanks.

[Roger Tawa OOO till Jul 10th, 2014-12-05 15:28:32]

lgtm

Good cleanup.

[noms (inactive), 2014-12-05 15:32:33]

noms@chromium.org changed reviewers:
+ dbeam@chromium.org, sky@chromium.org

[noms (inactive), 2014-12-05 15:32:34]

Adding Dan & Scott for owners stamp
- dbeam: c/b/resources/ntp4 and c/b/ui/webui/ntp
- sky: everything else

Thanks!

[sky, 2014-12-05 16:48:10]

LGTM

[noms (inactive), 2014-12-08 15:16:45]

ping dbeam

[Dan Beam, 2014-12-11 01:40:19]

lgtm

https://codereview.chromium.org/776423002/diff/1/chrome/browser/ui/webui/ntp/...
File chrome/browser/ui/webui/ntp/ntp_login_handler.cc (right):

https://codereview.chromium.org/776423002/diff/1/chrome/browser/ui/webui/ntp/...
chrome/browser/ui/webui/ntp/ntp_login_handler.cc:126: void
NTPLoginHandler::HandleShowSyncLoginUI(const base::ListValue* args) {
nit: I think the code makes more sense organized like this:

  Profile* profile = Profile::FromWebUI(web_ui());
  if (!signin::ShouldShowPromo(profile))
    return;

  std::string username = profile->GetPrefs()->GetString(
      prefs::kGoogleServicesUsername);
  if (!username.empty())
    return;

  content::WebContents* web_contents = web_ui()->GetWebContents();
  Browser* browser = chrome::FindBrowserWithWebContents(web_contents);
  if (!browser)
    return;

  ...

https://codereview.chromium.org/776423002/diff/1/chrome/browser/ui/webui/ntp/...
chrome/browser/ui/webui/ntp/ntp_login_handler.cc:141:
(web_contents->GetURL().spec() == chrome::kChromeUIAppsURL) ?
nit: unnecessary ()

[noms (inactive), 2014-12-12 18:19:30]

https://codereview.chromium.org/776423002/diff/1/chrome/browser/ui/webui/ntp/...
File chrome/browser/ui/webui/ntp/ntp_login_handler.cc (right):

https://codereview.chromium.org/776423002/diff/1/chrome/browser/ui/webui/ntp/...
chrome/browser/ui/webui/ntp/ntp_login_handler.cc:126: void
NTPLoginHandler::HandleShowSyncLoginUI(const base::ListValue* args) {
On 2014/12/11 01:40:19, Dan Beam wrote:
> nit: I think the code makes more sense organized like this:
> 
>   Profile* profile = Profile::FromWebUI(web_ui());
>   if (!signin::ShouldShowPromo(profile))
>     return;
> 
>   std::string username = profile->GetPrefs()->GetString(
>       prefs::kGoogleServicesUsername);
>   if (!username.empty())
>     return;
> 
>   content::WebContents* web_contents = web_ui()->GetWebContents();
>   Browser* browser = chrome::FindBrowserWithWebContents(web_contents);
>   if (!browser)
>     return;
> 
>   ...

Done.

https://codereview.chromium.org/776423002/diff/1/chrome/browser/ui/webui/ntp/...
chrome/browser/ui/webui/ntp/ntp_login_handler.cc:141:
(web_contents->GetURL().spec() == chrome::kChromeUIAppsURL) ?
On 2014/12/11 01:40:19, Dan Beam wrote:
> nit: unnecessary ()

Done.

[noms (inactive), 2014-12-12 21:57:24]

Patchset #3 (id:40001) has been deleted

[noms (inactive), 2014-12-15 14:21:05]

The CQ bit was checked by noms@chromium.org

[commit-bot: I haz the power, 2014-12-15 14:21:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/776423002/60001

[commit-bot: I haz the power, 2014-12-15 15:04:41]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2014-12-15 15:05:50]

Patchset 3 (id:??) landed as
https://crrev.com/9b525b712fffe4a445e38fec56ac72b607242ac3
Cr-Commit-Position: refs/heads/master@{#308349}