The Apps ntp page should not display an avatar menu when clicking on the username.

chrome/browser/ui/webui/ntp/ntp_login_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/ntp/ntp_login_handler.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 105 matching lines @@
                               const content::NotificationSource& source,
                               const content::NotificationDetails& details) {
   DCHECK_EQ(chrome::NOTIFICATION_PROFILE_CACHED_INFO_CHANGED, type);
   UpdateLogin();
 }
 
 void NTPLoginHandler::HandleInitializeSyncLogin(const base::ListValue* args) {
   UpdateLogin();
 }
 
 void NTPLoginHandler::HandleShowSyncLoginUI(const base::ListValue* args) {

[Dan Beam, 2014/12/11 01:40:19]

nit: I think the code makes more sense organized like this:

  Profile* profile = Profile::FromWebUI(web_ui());
  if (!signin::ShouldShowPromo(profile))
    return;

  std::string username = profile->GetPrefs()->GetString(
      prefs::kGoogleServicesUsername);
  if (!username.empty())
    return;

  content::WebContents* web_contents = web_ui()->GetWebContents();
  Browser* browser = chrome::FindBrowserWithWebContents(web_contents);
  if (!browser)
    return;

  ...

[noms (inactive), 2014/12/12 18:19:30]

Done.

   Profile* profile = Profile::FromWebUI(web_ui());
   std::string username = profile->GetPrefs()->GetString(
       prefs::kGoogleServicesUsername);
   content::WebContents* web_contents = web_ui()->GetWebContents();
   Browser* browser = chrome::FindBrowserWithWebContents(web_contents);
   if (!browser)
     return;
 
-  if (username.empty()) {
-    // The user isn't signed in, show the sign in promo.
-    if (signin::ShouldShowPromo(profile)) {
-      signin::Source source =
-          (web_contents->GetURL().spec() == chrome::kChromeUIAppsURL) ?
-              signin::SOURCE_APPS_PAGE_LINK :
-              signin::SOURCE_NTP_LINK;
-      chrome::ShowBrowserSignin(browser, source);
-      RecordInHistogram(NTP_SIGN_IN_PROMO_CLICKED);
-    }
-  } else if (args->GetSize() == 4) {
-    // The user is signed in, show the profiles menu.
-    double x = 0;
-    double y = 0;
-    double width = 0;
-    double height = 0;
-    bool success = args->GetDouble(0, &x);
-    DCHECK(success);
-    success = args->GetDouble(1, &y);
-    DCHECK(success);
-    success = args->GetDouble(2, &width);
-    DCHECK(success);
-    success = args->GetDouble(3, &height);
-    DCHECK(success);
+  if (!username.empty())
+    return;
 
-    double zoom = content::ZoomLevelToZoomFactor(
-        ZoomController::FromWebContents(web_contents)->GetZoomLevel());
-    gfx::Rect rect(x * zoom, y * zoom, width * zoom, height * zoom);
-
-    browser->window()->ShowAvatarBubble(web_ui()->GetWebContents(), rect);
-    ProfileMetrics::LogProfileOpenMethod(ProfileMetrics::NTP_AVATAR_BUBBLE);
+  // The user isn't signed in, show the sign in promo.
+  if (signin::ShouldShowPromo(profile)) {
+    signin::Source source =
+        (web_contents->GetURL().spec() == chrome::kChromeUIAppsURL) ?

[Dan Beam, 2014/12/11 01:40:19]

nit: unnecessary ()

[noms (inactive), 2014/12/12 18:19:30]

Done.

+            signin::SOURCE_APPS_PAGE_LINK :
+            signin::SOURCE_NTP_LINK;
+    chrome::ShowBrowserSignin(browser, source);
+    RecordInHistogram(NTP_SIGN_IN_PROMO_CLICKED);
   }
 }
 
 void NTPLoginHandler::RecordInHistogram(int type) {
   // Invalid type to record.
   if (type < NTP_SIGN_IN_PROMO_VIEWED ||
       type > NTP_SIGN_IN_PROMO_CLICKED) {
     NOTREACHED();
   } else {
     UMA_HISTOGRAM_ENUMERATION("SyncPromo.NTPPromo", type,
@@ skipping 99 matching lines @@
   values->SetString("login_status_message", message);
   values->SetString("login_status_url",
       hide_sync ? std::string() : chrome::kSyncLearnMoreURL);
   values->SetString("login_status_advanced",
       hide_sync ? base::string16() :
       l10n_util::GetStringUTF16(IDS_SYNC_PROMO_NTP_BUBBLE_ADVANCED));
   values->SetString("login_status_dismiss",
       hide_sync ? base::string16() :
       l10n_util::GetStringUTF16(IDS_SYNC_PROMO_NTP_BUBBLE_OK));
 }