Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 776143003: Remove Isolated Worlds from Sky (Closed)

Created:
6 years ago by eseidel
Modified:
6 years ago
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan, yurys
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove Isolated Worlds from Sky These were a feature for allowing multiple scripting contexts to access the same global state without leaking wrappers between them. For example, if the inspector wanted to modify window.Array.dangerousFunction = ... it wouldn't want the author's content to have access to that. This feature is not part of Sky's security model and thus this is just dead code. I tried to remove worlds all together, but there is something special about how we use a "fake" world (which is neither main nor isolated) for GC, regexp and testing. R=rafaelw@chromium.org, abarth@chromium.org BUG= Committed: https://chromium.googlesource.com/external/mojo/+/9c7118389a5a330d2f0b71dc503242a2f2062805

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -320 lines) Patch
M sky/engine/bindings/core/v8/CustomElementWrapper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/DOMDataStore.h View 1 chunk +2 lines, -3 lines 0 comments Download
M sky/engine/bindings/core/v8/DOMWrapperWorld.h View 4 chunks +7 lines, -22 lines 0 comments Download
M sky/engine/bindings/core/v8/DOMWrapperWorld.cpp View 3 chunks +5 lines, -83 lines 0 comments Download
M sky/engine/bindings/core/v8/ScriptController.h View 2 chunks +1 line, -11 lines 0 comments Download
M sky/engine/bindings/core/v8/ScriptController.cpp View 3 chunks +7 lines, -61 lines 0 comments Download
M sky/engine/bindings/core/v8/SerializedScriptValue.cpp View 1 chunk +4 lines, -16 lines 0 comments Download
M sky/engine/bindings/core/v8/V8Binding.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/V8GCController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/V8PerIsolateData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/WindowProxy.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/bindings/core/v8/custom/V8CustomEventCustom.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/bindings/templates/interface.cpp View 1 chunk +0 lines, -17 lines 0 comments Download
M sky/engine/core/loader/EmptyClients.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/loader/FrameLoaderClient.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/public/web/WebFrame.h View 2 chunks +0 lines, -25 lines 0 comments Download
M sky/engine/public/web/WebFrameClient.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/web/FrameLoaderClientImpl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/web/FrameLoaderClientImpl.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M sky/engine/web/WebLocalFrameImpl.h View 1 chunk +0 lines, -7 lines 0 comments Download
M sky/engine/web/WebLocalFrameImpl.cpp View 2 chunks +0 lines, -48 lines 0 comments Download
M sky/viewer/document_view.h View 1 chunk +1 line, -3 lines 0 comments Download
M sky/viewer/document_view.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
eseidel
6 years ago (2014-12-03 23:35:12 UTC) #1
rafaelw
lgtm
6 years ago (2014-12-03 23:45:25 UTC) #3
eseidel
6 years ago (2014-12-03 23:51:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9c7118389a5a330d2f0b71dc503242a2f2062805 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698