Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1622)

Unified Diff: sky/engine/public/web/WebFrame.h

Issue 776143003: Remove Isolated Worlds from Sky (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/loader/FrameLoaderClient.h ('k') | sky/engine/public/web/WebFrameClient.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/public/web/WebFrame.h
diff --git a/sky/engine/public/web/WebFrame.h b/sky/engine/public/web/WebFrame.h
index c04fea68dcfa46a6611f9173e4abe56be4ce8a62..46e61a80918fc58dcbba4bb988f1b056af184320 100644
--- a/sky/engine/public/web/WebFrame.h
+++ b/sky/engine/public/web/WebFrame.h
@@ -128,25 +128,6 @@ public:
// Executes script in the context of the current page.
virtual void executeScript(const WebScriptSource&) = 0;
- // Executes JavaScript in a new world associated with the web frame.
- // The script gets its own global scope and its own prototypes for
- // intrinsic JavaScript objects (String, Array, and so-on). It also
- // gets its own wrappers for all DOM nodes and DOM constructors.
- // extensionGroup is an embedder-provided specifier that controls which
- // v8 extensions are loaded into the new context - see
- // blink::registerExtension for the corresponding specifier.
- //
- // worldID must be > 0 (as 0 represents the main world).
- // worldID must be < EmbedderWorldIdLimit, high number used internally.
- virtual void executeScriptInIsolatedWorld(
- int worldID, const WebScriptSource* sources, unsigned numSources,
- int extensionGroup) = 0;
-
- // Associates an isolated world with human-readable name which is useful for
- // extension debugging.
- virtual void setIsolatedWorldHumanReadableName(
- int worldID, const WebString&) = 0;
-
// Logs to the console associated with this frame.
virtual void addMessageToConsole(const WebConsoleMessage&) = 0;
@@ -163,12 +144,6 @@ public:
virtual v8::Handle<v8::Value> executeScriptAndReturnValueForTests(
const WebScriptSource&);
- // worldID must be > 0 (as 0 represents the main world).
- // worldID must be < EmbedderWorldIdLimit, high number used internally.
- virtual void executeScriptInIsolatedWorld(
- int worldID, const WebScriptSource* sourcesIn, unsigned numSources,
- int extensionGroup, WebVector<v8::Local<v8::Value> >* results) = 0;
-
// Call the function with the given receiver and arguments, bypassing
// canExecute().
virtual v8::Handle<v8::Value> callFunctionEvenIfScriptDisabled(
« no previous file with comments | « sky/engine/core/loader/FrameLoaderClient.h ('k') | sky/engine/public/web/WebFrameClient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698