sky/engine/bindings/core/v8/V8Binding.cpp - Issue 776143003: Remove Isolated Worlds from Sky

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/bindings/core/v8/V8Binding.cpp

Issue 776143003: Remove Isolated Worlds from Sky (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/bindings/core/v8/V8Binding.cpp

diff --git a/sky/engine/bindings/core/v8/V8Binding.cpp b/sky/engine/bindings/core/v8/V8Binding.cpp

index 5f5de71d450f39c70b2ae2f383851542c8c5fe4a..7c323bb1fa453b734a5749f34059b3cc8aa9cc03 100644

--- a/sky/engine/bindings/core/v8/V8Binding.cpp

+++ b/sky/engine/bindings/core/v8/V8Binding.cpp

@@ -817,7 +817,7 @@ PassRefPtr<JSONValue> v8ToJSONValue(v8::Isolate* isolate, v8::Handle<v8::Value>

V8TestingScope::V8TestingScope(v8::Isolate* isolate)

: m_handleScope(isolate)

, m_contextScope(v8::Context::New(isolate))

- , m_scriptState(ScriptStateForTesting::create(isolate->GetCurrentContext(), DOMWrapperWorld::create()))

+ , m_scriptState(ScriptStateForTesting::create(isolate->GetCurrentContext(), DOMWrapperWorld::create(FakeWorld)))

{

}