Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 775803002: Remove heap/Handle usage from v8_inspector (Closed)

Created:
6 years ago by eseidel
Modified:
6 years ago
Reviewers:
yurys
CC:
mojo-reviews_chromium.org, ojan, esprehn, abarth-chromium
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove heap/Handle usage from v8_inspector I also removed it from a bunch of core/ as almost all the places its included it is not actually needed. BUG=435243 TBR=yurys@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/72cac2444b3666913d754b3c094576281e8e3838

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -37 lines) Patch
M sky/engine/bindings/core/v8/CustomElementWrapper.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/bindings/core/v8/ScriptPromise.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/bindings/core/v8/ScriptWrappable.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/bindings/core/v8/SerializedScriptValue.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/bindings/core/v8/WindowProxy.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/bindings/core/v8/WrapperTypeInfo.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/build/scripts/templates/ElementFactory.h.tmpl View 1 chunk +2 lines, -3 lines 0 comments Download
M sky/engine/core/animation/Animation.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/animation/AnimationEffect.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/animation/AnimationNode.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/animation/KeyframeEffectModel.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/animation/animatable/AnimatableValue.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/BasicShapeFunctions.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/CSSFilterRule.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/CSSFontFaceRule.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/CSSFontSelector.h View 3 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/core/css/CSSSegmentedFontFace.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/DocumentFontFaceSet.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/MediaQueryListListener.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/css/StyleRule.h View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/inspector/ScriptArguments.h View 1 chunk +1 line, -0 lines 0 comments Download
M sky/engine/v8_inspector/InspectorBaseAgent.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/v8_inspector/InspectorState.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
eseidel
Committed patchset #1 (id:1) manually as 72cac2444b3666913d754b3c094576281e8e3838 (presubmit successful).
6 years ago (2014-12-02 22:29:20 UTC) #1
yurys
6 years ago (2014-12-03 07:26:09 UTC) #2
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698