Issue 775793003: gn format: don't break+indent if it's going to be forced past 80col anyway

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 775793003: gn format: don't break+indent if it's going to be forced past 80col anyway (Closed)

Created:
6 years ago by scottmg

Modified:
6 years ago

Reviewers:
Dirk Pranke, brettw

CC:
chromium-reviews, tfarina

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

gn format: don't break+indent if it's going to be forced past 80col anyway A penalty is accrued for each character past 80col, but when both breaking and not breaking are too long, don't break because it doesn't help readability. R=brettw@chromium.org,dpranke@chromium.org BUG=348474 Committed: https://crrev.com/5cd14553570320fa95a467cdd4f2fdd42945b73f Cr-Commit-Position: refs/heads/master@{#306515}

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -9 lines)			Patch
M	tools/gn/command_format.cc	View	3 chunks	+23 lines, -1 line	0 comments	Download
M	tools/gn/command_format_unittest.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/gn/format_test_data/043.gn	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	tools/gn/format_test_data/043.golden	View	1 chunk	+2 lines, -5 lines	0 comments	Download
A	tools/gn/format_test_data/060.gn	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	tools/gn/format_test_data/060.golden	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/775793003/1

6 years ago (2014-12-03 00:49:29 UTC) #4

commit-bot: I haz the power

6 years ago (2014-12-03 01:14:36 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/5cd14553570320fa95a467cdd4f2fdd42945b73f
Cr-Commit-Position: refs/heads/master@{#306515}