Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: tools/gn/format_test_data/043.gn

Issue 775793003: gn format: don't break+indent if it's going to be forced past 80col anyway (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/command_format_unittest.cc ('k') | tools/gn/format_test_data/043.golden » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/format_test_data/043.gn
diff --git a/tools/gn/format_test_data/043.gn b/tools/gn/format_test_data/043.gn
index a2748d5ae3c1a90d66467930500fdf8de17c453a..b95c6a525932735a5de4aac734b22696ba2be490 100644
--- a/tools/gn/format_test_data/043.gn
+++ b/tools/gn/format_test_data/043.gn
@@ -1,6 +1,4 @@
-# We might prefer not to break the first one since it still exceeds the maximum
-# width. At the moment, each character past the end is a greater penalty, so
-# breaking to +4 is "better".
+# Don't break and indent when it's hopeless.
# 80 ---------------------------------------------------------------------------
android_java_prebuilt("android_support_v13_java") {
jar_path = "$android_sdk_root/extras/android/support/v7/appcompat/libs/android-support-v7-appcompat.jar"
« no previous file with comments | « tools/gn/command_format_unittest.cc ('k') | tools/gn/format_test_data/043.golden » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698