tools/gn/format_test_data/043.golden - Issue 775793003: gn format: don't break+indent if it's going to be forced past 80col anyway

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/format_test_data/043.golden

Issue 775793003: gn format: don't break+indent if it's going to be forced past 80col anyway (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/format_test_data/043.golden

diff --git a/tools/gn/format_test_data/043.golden b/tools/gn/format_test_data/043.golden

index 5ba421b89a86a42d9083d6db047ae4f3eb72ed49..336ec2fff1ea7af85533f15e34ccdcbea35d5851 100644

--- a/tools/gn/format_test_data/043.golden

+++ b/tools/gn/format_test_data/043.golden

@@ -1,10 +1,7 @@

-# We might prefer not to break the first one since it still exceeds the maximum

-# width. At the moment, each character past the end is a greater penalty, so

-# breaking to +4 is "better".

+# Don't break and indent when it's hopeless.

# 80 ---------------------------------------------------------------------------

android_java_prebuilt("android_support_v13_java") {

- jar_path =

- "$android_sdk_root/extras/android/support/v7/appcompat/libs/android-support-v7-appcompat.jar"

+ jar_path = "$android_sdk_root/extras/android/support/v7/appcompat/libs/android-support-v7-appcompat.jar"

jar_path =

"$android_sdk_root/extras/android/support/v13/android-support-v13.jar"

}

« no previous file with comments | « tools/gn/format_test_data/043.gn ('k') | tools/gn/format_test_data/060.gn » ('j') | no next file with comments »