Add a setting to determine whether showing context menu on mouse up.

Add a setting to determine whether showing context menu on mouse up.

The setting is used to determine whether showing context menu on mouse up.
This is false by default and will be used for some layout tests.

Used/tested here: https://codereview.chromium.org/776483002/

BUG=438544
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186472

[zino, 2014-12-02 18:00:52]

jinho.bang@samsung.com changed reviewers:
+ rbyers@chromium.org

[zino, 2014-12-02 18:01:13]

Dear Rick,

Please take a look.

[Rick Byers, 2014-12-02 19:20:37]

This looks good.  Please file a bug that tracks the collection of changes.

https://codereview.chromium.org/775553002/diff/1/Source/core/frame/Settings.in
File Source/core/frame/Settings.in (right):

https://codereview.chromium.org/775553002/diff/1/Source/core/frame/Settings.i...
Source/core/frame/Settings.in:315: # If true, context menu will be shown on
mouse up instead of mouse down.
Please add one more comment line justifying why we should have a setting for
this, eg: "# Typically enabled on Windows to match platform convention."

[zino, 2014-12-03 02:34:51]

Patchset #2 (id:20001) has been deleted

[zino, 2014-12-03 08:24:52]

Thank you for review.

Please take a look again :)

https://codereview.chromium.org/775553002/diff/1/Source/core/frame/Settings.in
File Source/core/frame/Settings.in (right):

https://codereview.chromium.org/775553002/diff/1/Source/core/frame/Settings.i...
Source/core/frame/Settings.in:315: # If true, context menu will be shown on
mouse up instead of mouse down.
On 2014/12/02 19:20:37, Rick Byers wrote:
> Please add one more comment line justifying why we should have a setting for
> this, eg: "# Typically enabled on Windows to match platform convention."

Done.

[zino, 2014-12-03 12:33:09]

I added @haraken as reviewer for web/*.

Thank you.

[zino, 2014-12-03 12:34:17]

jinho.bang@samsung.com changed reviewers:
+ haraken@chromium.org

[zino, 2014-12-03 12:35:45]

Please take a look.

I added @haraken as reviewer for web/*.
(public/web/* is okay because @Rick is already owner in the directory.)

Thank you.

[Rick Byers, 2014-12-03 13:44:39]

Thanks, LGTM

[haraken, 2014-12-03 15:12:34]

Source/web/ LGTM, but this needs an approval of an API owner.

[zino, 2014-12-03 15:22:44]

jinho.bang@samsung.com changed reviewers:
+ pdr@chromium.org

[zino, 2014-12-03 15:24:48]

On 2014/12/03 15:12:34, haraken wrote:
> Source/web/ LGTM, but this needs an approval of an API owner.

Dear @pdr,

This CL needs your approval (as API owner).
Could you review this?

Thank you.

[Rick Byers, 2014-12-03 17:19:51]

On 2014/12/03 15:12:34, haraken wrote:
> Source/web/ LGTM, but this needs an approval of an API owner.

You mean a public/web OWNER?  I've given my approval already (but happy for pdr@
to chime in if he disagrees).  So this CL is good to go.

[pdr., 2014-12-03 21:06:23]

On 2014/12/03 at 15:24:48, jinho.bang wrote:
> On 2014/12/03 15:12:34, haraken wrote:
> > Source/web/ LGTM, but this needs an approval of an API owner.
> 
> Dear @pdr,
> 
> This CL needs your approval (as API owner).
> Could you review this?
> 
> Thank you.

Rick and Kentaro are experts in this area and should have all the owners bits
needed. The api owners thing is just for releasing features.

[pdr., 2014-12-03 21:06:42]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2014-12-03 21:07:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/775553002/40001

[haraken, 2014-12-03 23:26:22]

On 2014/12/03 17:19:51, Rick Byers wrote:
> On 2014/12/03 15:12:34, haraken wrote:
> > Source/web/ LGTM, but this needs an approval of an API owner.
> 
> You mean a public/web OWNER?  I've given my approval already (but happy for
pdr@
> to chime in if he disagrees).  So this CL is good to go.

Sorry, I meant that ^^^

[commit-bot: I haz the power, 2014-12-03 23:47:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-03 23:47:24]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/39677)

[pdr., 2014-12-04 00:07:48]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2014-12-04 00:08:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/775553002/40001

[commit-bot: I haz the power, 2014-12-04 02:09:48]

Committed patchset #2 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186472