Source/core/frame/Settings.in - Issue 775553002: Add a setting to determine whether showing context menu on mouse up.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/frame/Settings.in

Issue 775553002: Add a setting to determine whether showing context menu on mouse up. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | Source/web/WebSettingsImpl.h » ('j') | no next file with comments »

OLD	NEW
1 # Defines properties which are available on the Settings object.	1 # Defines properties which are available on the Settings object.

2 #	2 #

3 # Please think carefully before adding a new Setting. Some questions to	3 # Please think carefully before adding a new Setting. Some questions to

4 # consider are:	4 # consider are:

5 # - Should this be a RuntimeEnabledFeature instead? Settings are for things	5 # - Should this be a RuntimeEnabledFeature instead? Settings are for things

6 # which we support either values of at runtime. Features are set at renderer	6 # which we support either values of at runtime. Features are set at renderer

7 # process startup and are never changed. Features also tend to be set to a	7 # process startup and are never changed. Features also tend to be set to a

8 # value based on the platform or the stability of the code in question, where	8 # value based on the platform or the stability of the code in question, where

9 # as settings both codepaths need to be stable.	9 # as settings both codepaths need to be stable.

10 # - How will you ensure test coverage of all relevant values of your setting?	10 # - How will you ensure test coverage of all relevant values of your setting?

(...skipping 293 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
304 primaryHoverType type=HoverType, initial=HoverTypeNone, invalidate=MediaQuery	304 primaryHoverType type=HoverType, initial=HoverTypeNone, invalidate=MediaQuery

305	305

306 # Whether accessibility support is enabled at all.	306 # Whether accessibility support is enabled at all.

307 accessibilityEnabled initial=false, invalidate=AccessibilityState	307 accessibilityEnabled initial=false, invalidate=AccessibilityState

308	308

309 # If true, the value in password fields is exposed to assistive technologies.	309 # If true, the value in password fields is exposed to assistive technologies.

310 accessibilityPasswordValuesEnabled initial=false	310 accessibilityPasswordValuesEnabled initial=false

311	311

312 # If true, static text nodes expose inline text box children.	312 # If true, static text nodes expose inline text box children.

313 inlineTextBoxAccessibilityEnabled initial=false	313 inlineTextBoxAccessibilityEnabled initial=false

	314

	315 # If true, context menu will be shown on mouse up instead of mouse down.
	Rick Byers 2014/12/02 19:20:37 Please add one more comment line justifying why we Please add one more comment line justifying why we should have a setting for this, eg: "# Typically enabled on Windows to match platform convention." zino 2014/12/03 08:24:52 Done. Show quoted text On 2014/12/02 19:20:37, Rick Byers wrote: > Please add one more comment line justifying why we should have a setting for > this, eg: "# Typically enabled on Windows to match platform convention." Done.
	316 showContextMenuOnMouseUp initial=false

OLD	NEW