Tweak NSUserActivity forward declaration

Tweak NSUserActivity forward declaration

Change property from webPageURL to webpageURL as recommended by Apple.
(Using webPageURL will trigger warning on console.)

Committed: https://crrev.com/c0c568c37bd1cfe742902318f597a58f49092651
Cr-Commit-Position: refs/heads/master@{#306862}

[Jiang Jiang, 2014-12-04 13:52:58]

jiangj@opera.com changed reviewers:
+ thakis@chromium.org

[Jiang Jiang, 2014-12-04 13:52:59]

Nico, do you mind take a look?

CCing erikchen since he did the Handoff receiving work for Chrome.

[Nico, 2014-12-04 17:15:25]

the webpageURL lgtm; I don't understand the need for the other 3 functions.

https://codereview.chromium.org/775313002/diff/1/base/mac/sdk_forward_declara...
File base/mac/sdk_forward_declarations.h (right):

https://codereview.chromium.org/775313002/diff/1/base/mac/sdk_forward_declara...
base/mac/sdk_forward_declarations.h:333: -
(instancetype)initWithActivityType:(NSString*)activityType;
Why are you adding these 3? It looks like you're not adding any calls to them.

https://codereview.chromium.org/775313002/diff/1/base/mac/sdk_forward_declara...
base/mac/sdk_forward_declarations.h:339: @property (copy) NSURL* webpageURL;
Whoa, how did this work before? :-/

[Jiang Jiang, 2014-12-04 17:25:11]

https://codereview.chromium.org/775313002/diff/1/base/mac/sdk_forward_declara...
File base/mac/sdk_forward_declarations.h (right):

https://codereview.chromium.org/775313002/diff/1/base/mac/sdk_forward_declara...
base/mac/sdk_forward_declarations.h:333: -
(instancetype)initWithActivityType:(NSString*)activityType;
On 2014/12/04 17:15:25, Nico wrote:
> Why are you adding these 3? It looks like you're not adding any calls to them.

It's just to make it easier to add Handoff support from desktop to iOS. We have
done it in Opera but I'm not sure about Chrome's plan, I assume that it will
support it sometime in the future.

I can remove them if you think it's best to add them when they are being used.

https://codereview.chromium.org/775313002/diff/1/base/mac/sdk_forward_declara...
base/mac/sdk_forward_declarations.h:339: @property (copy) NSURL* webpageURL;
On 2014/12/04 17:15:25, Nico wrote:
> Whoa, how did this work before? :-/

Current Yosemite still accepts webPageURL but it warnings about it in console, I
think it's because pre-release version of Yosemite SDK used the old form and
they change later.

[Nico, 2014-12-04 17:30:36]

webpageURL change lgtm, please remove the rest for now and land.

https://codereview.chromium.org/775313002/diff/1/base/mac/sdk_forward_declara...
File base/mac/sdk_forward_declarations.h (right):

https://codereview.chromium.org/775313002/diff/1/base/mac/sdk_forward_declara...
base/mac/sdk_forward_declarations.h:333: -
(instancetype)initWithActivityType:(NSString*)activityType;
On 2014/12/04 17:25:11, Jiang Jiang wrote:
> On 2014/12/04 17:15:25, Nico wrote:
> > Why are you adding these 3? It looks like you're not adding any calls to
them.
> 
> It's just to make it easier to add Handoff support from desktop to iOS. We
have
> done it in Opera but I'm not sure about Chrome's plan, I assume that it will
> support it sometime in the future.
> 
> I can remove them if you think it's best to add them when they are being used.

Please do, let's not add dead code. We can add it when there are callers.

(Is there a way to factor the code that the handoff code is shared between
chromium and opera?)

https://codereview.chromium.org/775313002/diff/1/base/mac/sdk_forward_declara...
base/mac/sdk_forward_declarations.h:339: @property (copy) NSURL* webpageURL;
On 2014/12/04 17:25:11, Jiang Jiang wrote:
> On 2014/12/04 17:15:25, Nico wrote:
> > Whoa, how did this work before? :-/
> 
> Current Yosemite still accepts webPageURL but it warnings about it in console,
I
> think it's because pre-release version of Yosemite SDK used the old form and
> they change later.

Ah, ok.

[Jiang Jiang, 2014-12-04 18:04:42]

https://codereview.chromium.org/775313002/diff/1/base/mac/sdk_forward_declara...
File base/mac/sdk_forward_declarations.h (right):

https://codereview.chromium.org/775313002/diff/1/base/mac/sdk_forward_declara...
base/mac/sdk_forward_declarations.h:333: -
(instancetype)initWithActivityType:(NSString*)activityType;
On 2014/12/04 17:30:36, Nico wrote:
> Please do, let's not add dead code. We can add it when there are callers.
> 
> (Is there a way to factor the code that the handoff code is shared between
> chromium and opera?)

Done.

Currently Chrome put all Handoff logic in app_controller_mac.mm which is the
NSApplicationDelegate, so does Opera.

It's possible to factor out the Handoff broadcasting logic to content and
associate a NSUserActivity per RenderWidgetHostViewCocoa or
WebContentsViewCocoa, so that once that view become firstResponder AppKit will
automagically make the broadcast for us. That's according to the documentation
but I haven't tried it myself. What I did for now is to keep one NSUserActivity
instance per application and update it when active tab or window focus changes.

[Jiang Jiang, 2014-12-04 18:05:20]

The CQ bit was checked by jiangj@opera.com

[commit-bot: I haz the power, 2014-12-04 18:06:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/775313002/20001

[Jiang Jiang, 2014-12-04 18:08:57]

The CQ bit was unchecked by jiangj@opera.com

[Jiang Jiang, 2014-12-04 18:09:06]

The CQ bit was checked by jiangj@opera.com

[commit-bot: I haz the power, 2014-12-04 18:09:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/775313002/20001

[erikchen, 2014-12-04 18:35:06]

On 2014/12/04 18:09:19, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/775313002/20001

We are literally landing the exact same CL at the same time:
https://codereview.chromium.org/776173002/
I'll cancel mine.

[commit-bot: I haz the power, 2014-12-04 19:02:20]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-12-04 19:03:09]

Patchset 2 (id:??) landed as
https://crrev.com/c0c568c37bd1cfe742902318f597a58f49092651
Cr-Commit-Position: refs/heads/master@{#306862}

[Jiang Jiang, 2014-12-04 19:23:31]

On 2014/12/04 18:35:06, erikchen wrote:
> On 2014/12/04 18:09:19, I haz the power (commit-bot) wrote:
> > CQ is trying da patch. Follow status at
> >  https://chromium-cq-status.appspot.com/patch-status/775313002/20001
> 
> We are literally landing the exact same CL at the same time:
> https://codereview.chromium.org/776173002/
> I'll cancel mine.

Thanks, I didn't know that when I sent this.