Tweak NSUserActivity forward declaration

base/mac/sdk_forward_declarations.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file contains forward declarations for items in later SDKs than the
 // default one with which Chromium is built (currently 10.6).
 // If you call any function from this header, be sure to check at runtime for
 // respondsToSelector: before calling these functions (else your code will crash
 // on older OS X versions that chrome still supports).
 
@@ skipping 312 matching lines @@
 
 BASE_EXPORT extern "C" NSString* const kCWSSIDDidChangeNotification;
 
 #endif  // MAC_OS_X_VERSION_10_9
 
 #if !defined(MAC_OS_X_VERSION_10_10) || \
     MAC_OS_X_VERSION_MAX_ALLOWED < MAC_OS_X_VERSION_10_10
 
 @interface NSUserActivity : NSObject
 
+- (instancetype)initWithActivityType:(NSString*)activityType;

[Nico, 2014/12/04 17:15:25]

Why are you adding these 3? It looks like you're not adding any calls to them.

[Jiang Jiang, 2014/12/04 17:25:11]

It's just to make it easier to add Handoff support from desktop to iOS. We have
done it in Opera but I'm not sure about Chrome's plan, I assume that it will
support it sometime in the future.

I can remove them if you think it's best to add them when they are being used.

[Nico, 2014/12/04 17:30:36]

Please do, let's not add dead code. We can add it when there are callers.

(Is there a way to factor the code that the handoff code is shared between
chromium and opera?)

[Jiang Jiang, 2014/12/04 18:04:42]

Done.

Currently Chrome put all Handoff logic in app_controller_mac.mm which is the
NSApplicationDelegate, so does Opera.

It's possible to factor out the Handoff broadcasting logic to content and
associate a NSUserActivity per RenderWidgetHostViewCocoa or
WebContentsViewCocoa, so that once that view become firstResponder AppKit will
automagically make the broadcast for us. That's according to the documentation
but I haven't tried it myself. What I did for now is to keep one NSUserActivity
instance per application and update it when active tab or window focus changes.

+- (void)becomeCurrent;
+- (void)invalidate;
+
 @property (readonly, copy) NSString* activityType;
 @property (copy) NSDictionary* userInfo;
-@property (copy) NSURL* webPageURL;
+@property (copy) NSURL* webpageURL;

[Nico, 2014/12/04 17:15:25]

Whoa, how did this work before? :-/

[Jiang Jiang, 2014/12/04 17:25:11]

Current Yosemite still accepts webPageURL but it warnings about it in console, I
think it's because pre-release version of Yosemite SDK used the old form and
they change later.

[Nico, 2014/12/04 17:30:36]

Ah, ok.

 
 @end
 
 BASE_EXPORT extern "C" NSString* const NSUserActivityTypeBrowsingWeb;
 
 BASE_EXPORT extern "C" NSString* const NSAppearanceNameVibrantDark;
 
 #endif  // MAC_OS_X_VERSION_10_10
 
 #endif  // BASE_MAC_SDK_FORWARD_DECLARATIONS_H_