Issue 776173002: Change -[NSUserActivity webPageURL] to -[NSUserActivity webpageURL]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 776173002: Change -[NSUserActivity webPageURL] to -[NSUserActivity webpageURL] (Closed)

Created:
6 years ago by erikchen

Modified:
6 years ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Change -[NSUserActivity webPageURL] to -[NSUserActivity webpageURL] Sometime between OSX 10.10 DP1 and OSX 10.10 DP5, Apple changed the spelling of the property 'webPageURL' to 'webpageURL'. They updated their public documentation and header files, but the AppKit framework still allowed the use of webPageURL (it redirects internally to webpageURL). BUG=438898

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	base/mac/sdk_forward_declarations.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/app_controller_mac.mm	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/776173002/1

6 years ago (2014-12-04 18:34:40 UTC) #5

erikchen

6 years ago (2014-12-04 23:27:26 UTC) #7

Message was sent while issue was closed.

jiang landed the exact same fix slightly right before this fix would have
landed.

https://codereview.chromium.org/775313002/

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages