Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 774353003: gn format // (the rest) (Closed)

Created:
6 years ago by scottmg
Modified:
6 years ago
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, zea+watch_chromium.org, viettrungluu+watch_chromium.org, posciak+watch_chromium.org, browser-components-watch_chromium.org, jln+watch_chromium.org, yzshen+watch_chromium.org, yukishiino+watch_chromium.org, hguihot+watch_chromium.org, klundberg+watch_chromium.org, noyau+watch_chromium.org, pvalenzuela+watch_chromium.org, Ilya Sherman, mikhal+watch_chromium.org, tim+watch_chromium.org, ozone-reviews_chromium.org, cbentzel+watch_chromium.org, eme-reviews_chromium.org, benquan, stevenjb+watch_chromium.org, chromoting-reviews_chromium.org, jam, ben+mojo_chromium.org, abarth-chromium, nona+watch_chromium.org, darin-cc_chromium.org, jochen+watch_chromium.org, kalyank, erikwright+watch_chromium.org, jbudorick+watch_chromium.org, hubbe+watch_chromium.org, yfriedman+watch_chromium.org, mlamouri+watch-content_chromium.org, imcheng+watch_chromium.org, qsr+mojo_chromium.org, jasonroberts+watch_google.com, miu+watch_chromium.org, feature-media-reviews_chromium.org, dsinclair+watch_chromium.org, oshima+watch_chromium.org, piman+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, darin (slow to review), rouslan+autofillwatch_chromium.org, maniscalco+watch_chromium.org, hclam+watch_chromium.org, Dai Mikurube (NOT FULLTIME), wfh+watch_chromium.org, maxbogue+watch_chromium.org, avayvod+watch_chromium.org, mcasas+watch_chromium.org, pwestin+watch_google.com, Aaron Boodman, Dane Wallinga, dyu1, tfarina, estade+watch_chromium.org, cc-bugs_chromium.org, wjia+watch_chromium.org, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

gn format // (the rest, except mojo) Excluded mojo because I think that needs to happen on the other side. At gn --version = 306668 for which roll is in CQ. R=brettw@chromium.org TBR=scherkus@chromium.org BUG=348474 Committed: https://crrev.com/34fb7e5919ed42dc800acf3961fe6a2bf9e7d6eb Cr-Commit-Position: refs/heads/master@{#306708}

Patch Set 1 #

Patch Set 2 : rebase net #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1332 lines, -1226 lines) Patch
M .gn View 1 chunk +1 line, -3 lines 0 comments Download
M BUILD.gn View 4 chunks +6 lines, -11 lines 0 comments Download
M ash/BUILD.gn View 8 chunks +14 lines, -21 lines 0 comments Download
M base/allocator/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M breakpad/BUILD.gn View 13 chunks +25 lines, -22 lines 0 comments Download
M build/config/android/config.gni View 2 chunks +6 lines, -12 lines 0 comments Download
M build/config/android/internal_rules.gni View 3 chunks +12 lines, -4 lines 0 comments Download
M build/config/android/rules.gni View 2 chunks +4 lines, -3 lines 0 comments Download
M build/go/rules.gni View 2 chunks +6 lines, -2 lines 0 comments Download
M build/secondary/third_party/android_tools/BUILD.gn View 2 chunks +2 lines, -4 lines 0 comments Download
M build/secondary/third_party/icu/BUILD.gn View 2 chunks +6 lines, -2 lines 0 comments Download
M build/secondary/tools/grit/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M build/secondary/tools/grit/repack.gni View 1 chunk +3 lines, -1 line 0 comments Download
M build/toolchain/android/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M build/toolchain/gcc_toolchain.gni View 5 chunks +23 lines, -25 lines 0 comments Download
M build/toolchain/mac/BUILD.gn View 4 chunks +34 lines, -39 lines 0 comments Download
M build/toolchain/nacl/BUILD.gn View 2 chunks +4 lines, -8 lines 0 comments Download
M build/toolchain/win/BUILD.gn View 5 chunks +22 lines, -24 lines 0 comments Download
M build/util/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M cc/surfaces/BUILD.gn View 2 chunks +3 lines, -2 lines 0 comments Download
M chromeos/BUILD.gn View 4 chunks +10 lines, -15 lines 0 comments Download
M chromeos/ime/BUILD.gn View 1 chunk +4 lines, -2 lines 0 comments Download
M components/autofill/core/browser/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M components/bookmarks/common/android/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M components/data_reduction_proxy/core/common/version.gni View 1 chunk +3 lines, -1 line 0 comments Download
M components/domain_reliability/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/tracing/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M content/shell/BUILD.gn View 4 chunks +12 lines, -4 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M courgette/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M crypto/BUILD.gn View 3 chunks +8 lines, -5 lines 0 comments Download
M dbus/BUILD.gn View 4 chunks +8 lines, -16 lines 0 comments Download
M device/battery/BUILD.gn View 3 chunks +11 lines, -33 lines 0 comments Download
M device/hid/BUILD.gn View 1 chunk +1 line, -3 lines 0 comments Download
M device/media_transfer_protocol/BUILD.gn View 1 chunk +6 lines, -2 lines 0 comments Download
M device/nfc/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M device/usb/BUILD.gn View 1 chunk +10 lines, -4 lines 0 comments Download
M google_apis/BUILD.gn View 1 chunk +6 lines, -5 lines 0 comments Download
M gpu/BUILD.gn View 2 chunks +3 lines, -6 lines 0 comments Download
M gpu/command_buffer/client/BUILD.gn View 4 chunks +16 lines, -6 lines 0 comments Download
M gpu/command_buffer/service/BUILD.gn View 2 chunks +4 lines, -4 lines 0 comments Download
M gpu/config/BUILD.gn View 3 chunks +6 lines, -8 lines 0 comments Download
M ipc/BUILD.gn View 2 chunks +2 lines, -4 lines 0 comments Download
M jingle/BUILD.gn View 3 chunks +8 lines, -7 lines 0 comments Download
M media/BUILD.gn View 11 chunks +60 lines, -62 lines 0 comments Download
M media/audio/BUILD.gn View 7 chunks +26 lines, -24 lines 0 comments Download
M media/base/BUILD.gn View 7 chunks +18 lines, -15 lines 0 comments Download
M media/base/android/BUILD.gn View 1 chunk +1 line, -3 lines 0 comments Download
M media/cast/BUILD.gn View 3 chunks +8 lines, -6 lines 0 comments Download
M media/cast/test/proto/BUILD.gn View 2 chunks +1 line, -4 lines 0 comments Download
M media/cdm/ppapi/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M media/mojo/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M media/mojo/services/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M net/BUILD.gn View 1 23 chunks +317 lines, -308 lines 0 comments Download
M net/android/BUILD.gn View 3 chunks +4 lines, -3 lines 0 comments Download
M net/base/registry_controlled_domains/BUILD.gn View 1 chunk +3 lines, -2 lines 0 comments Download
M net/third_party/nss/ssl/BUILD.gn View 2 chunks +2 lines, -6 lines 0 comments Download
M pdf/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/BUILD.gn View 5 chunks +10 lines, -14 lines 0 comments Download
M printing/BUILD.gn View 4 chunks +5 lines, -8 lines 0 comments Download
M remoting/base/BUILD.gn View 2 chunks +5 lines, -8 lines 0 comments Download
M remoting/client/BUILD.gn View 1 chunk +5 lines, -7 lines 0 comments Download
M remoting/client/plugin/BUILD.gn View 1 chunk +6 lines, -7 lines 0 comments Download
M remoting/host/BUILD.gn View 3 chunks +7 lines, -12 lines 0 comments Download
M remoting/host/it2me/BUILD.gn View 2 chunks +8 lines, -10 lines 0 comments Download
M remoting/proto/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/BUILD.gn View 1 chunk +6 lines, -7 lines 0 comments Download
M remoting/remoting_version.gni View 1 chunk +57 lines, -41 lines 0 comments Download
M remoting/resources/BUILD.gn View 5 chunks +69 lines, -62 lines 0 comments Download
M remoting/webapp/BUILD.gn View 6 chunks +21 lines, -26 lines 0 comments Download
M sandbox/BUILD.gn View 1 chunk +9 lines, -3 lines 0 comments Download
M sandbox/linux/BUILD.gn View 7 chunks +6 lines, -9 lines 0 comments Download
M sandbox/mac/BUILD.gn View 1 chunk +21 lines, -9 lines 0 comments Download
M sandbox/win/BUILD.gn View 2 chunks +4 lines, -2 lines 0 comments Download
M sdch/BUILD.gn View 1 chunk +6 lines, -2 lines 0 comments Download
M skia/BUILD.gn View 13 chunks +145 lines, -143 lines 0 comments Download
M sync/BUILD.gn View 6 chunks +7 lines, -10 lines 0 comments Download
M sync/internal_api/attachments/proto/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M testing/android/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M testing/android/junit/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M testing/perf/BUILD.gn View 1 chunk +6 lines, -2 lines 0 comments Download
M third_party/adobe/flash/BUILD.gn View 2 chunks +6 lines, -2 lines 0 comments Download
M third_party/cython/rules.gni View 2 chunks +6 lines, -3 lines 0 comments Download
M third_party/google_input_tools/closure.gni View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/opus/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/stp/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/widevine/cdm/BUILD.gn View 2 chunks +6 lines, -2 lines 0 comments Download
M third_party/yasm/BUILD.gn View 11 chunks +33 lines, -11 lines 0 comments Download
M third_party/yasm/yasm_assemble.gni View 1 chunk +3 lines, -1 line 0 comments Download
M tools/android/forwarder2/BUILD.gn View 1 chunk +6 lines, -2 lines 0 comments Download
M tools/android/md5sum/BUILD.gn View 3 chunks +5 lines, -5 lines 0 comments Download
M tools/generate_library_loader/generate_library_loader.gni View 3 chunks +24 lines, -8 lines 0 comments Download
M tools/gn/BUILD.gn View 2 chunks +12 lines, -4 lines 0 comments Download
M tools/gn/example/BUILD.gn View 2 chunks +4 lines, -2 lines 0 comments Download
M tools/gn/example/build/BUILDCONFIG.gn View 1 chunk +2 lines, -3 lines 0 comments Download
M tools/gn/example/build/toolchain/BUILD.gn View 2 chunks +4 lines, -2 lines 0 comments Download
M tools/json_schema_compiler/BUILD.gn View 1 chunk +4 lines, -3 lines 0 comments Download
M tools/json_to_struct/json_to_struct.gni View 1 chunk +3 lines, -1 line 0 comments Download
M tools/relocation_packer/BUILD.gn View 5 chunks +22 lines, -10 lines 0 comments Download
M tools/relocation_packer/config.gni View 1 chunk +3 lines, -4 lines 0 comments Download
M tools/xdisplaycheck/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/keyboard/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M ui/ozone/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M ui/resources/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M url/BUILD.gn View 2 chunks +3 lines, -9 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
scottmg
6 years ago (2014-12-03 22:33:12 UTC) #1
jamesr
You can do the mojo ones here too if you want, the changes will just ...
6 years ago (2014-12-03 22:35:16 UTC) #3
scottmg
On 2014/12/03 22:35:16, jamesr wrote: > You can do the mojo ones here too if ...
6 years ago (2014-12-03 22:39:04 UTC) #4
brettw
rs lgtm
6 years ago (2014-12-03 23:10:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/774353003/20001
6 years ago (2014-12-03 23:11:25 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/28076)
6 years ago (2014-12-03 23:18:33 UTC) #9
scottmg
tbr scherkus@ for third_party/widevine/cdm/BUILD.gn
6 years ago (2014-12-03 23:22:20 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/774353003/20001
6 years ago (2014-12-03 23:23:26 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-03 23:27:34 UTC) #14
commit-bot: I haz the power
6 years ago (2014-12-03 23:28:14 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/34fb7e5919ed42dc800acf3961fe6a2bf9e7d6eb
Cr-Commit-Position: refs/heads/master@{#306708}

Powered by Google App Engine
This is Rietveld 408576698