[Password Generation] Remove requirement that generation fields are visible

[Password Generation] Remove requirement that generation fields are visible

This is mostly a leftover from before Autofill integration. It was supposed
to help prevent triggering on sites that looks like they only have 2 input
fields, but actually have more hidden. It's not clear how much this actually
prevents generation from triggering in unwanted cases, but it is causing
false negatives on some major sites (Paypal and Etsy). Removeing the requirement
seems like the best option at the moment.

BUG=438554
Committed: https://crrev.com/84fafa340ca0c8a4e1859c4dabaea62702eac0f7
Cr-Commit-Position: refs/heads/master@{#306688}

[Garrett Casto, 2014-12-03 09:26:55]

gcasto@chromium.org changed reviewers:
+ vabr@chromium.org

[vabr (Chromium), 2014-12-03 10:03:07]

LGTM.
I believe this is reasonable. The worst which can happen for forms with
invisible inputs is that the user gets password generation offered on typing
their password. That would be a confusing UX, but not a blocking one. And since
neither of us knows about a page where this would happen, trading this off for
fixing paypal etc. looks like a good idea.

Cheers,
Vaclav

[vabr (Chromium), 2014-12-03 10:05:24]

https://codereview.chromium.org/774143003/diff/20001/components/autofill/cont...
File components/autofill/content/renderer/password_generation_agent.cc (right):

https://codereview.chromium.org/774143003/diff/20001/components/autofill/cont...
components/autofill/content/renderer/password_generation_agent.cc:46:
input_element->isTextField()) {
nit: The if-condition now fits on one line.

[Garrett Casto, 2014-12-03 20:58:59]

https://codereview.chromium.org/774143003/diff/20001/components/autofill/cont...
File components/autofill/content/renderer/password_generation_agent.cc (right):

https://codereview.chromium.org/774143003/diff/20001/components/autofill/cont...
components/autofill/content/renderer/password_generation_agent.cc:46:
input_element->isTextField()) {
On 2014/12/03 10:05:24, vabr (Chromium) wrote:
> nit: The if-condition now fits on one line.

Done.

[Garrett Casto, 2014-12-03 20:59:02]

The CQ bit was checked by gcasto@chromium.org

[commit-bot: I haz the power, 2014-12-03 20:59:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/774143003/40001

[commit-bot: I haz the power, 2014-12-03 22:25:13]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-12-03 22:26:22]

Patchset 3 (id:??) landed as
https://crrev.com/84fafa340ca0c8a4e1859c4dabaea62702eac0f7
Cr-Commit-Position: refs/heads/master@{#306688}