[Password Generation] Remove requirement that generation fields are visible

components/autofill/content/renderer/password_generation_agent.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/password_generation_agent.h"
 
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "components/autofill/content/common/autofill_messages.h"
@@ skipping 24 matching lines @@
     const blink::WebFormElement& form,
     std::vector<blink::WebInputElement>* passwords) {
   // Grab all of the passwords for the form.
   blink::WebVector<blink::WebFormControlElement> control_elements;
   form.getFormControlElements(control_elements);
 
   size_t num_input_elements = 0;
   for (size_t i = 0; i < control_elements.size(); i++) {
     blink::WebInputElement* input_element =
         toWebInputElement(&control_elements[i]);
-    // Only pay attention to visible password fields.
     if (input_element &&
-        input_element->isTextField() &&
-        input_element->hasNonEmptyBoundingBox()) {
+        input_element->isTextField()) {

[vabr (Chromium), 2014/12/03 10:05:24]

nit: The if-condition now fits on one line.

[Garrett Casto, 2014/12/03 20:58:58]

Done.

       num_input_elements++;
       if (input_element->isPasswordField())
         passwords->push_back(*input_element);
     }
   }
 
   // This may be too lenient, but we assume that any form with at least three
   // input elements where at least one of them is a password is an account
   // creation form.
   if (!passwords->empty() && num_input_elements >= 3) {
@@ skipping 344 matching lines @@
       *possible_account_creation_form_));
 
   editing_popup_shown_ = true;
 }
 
 void PasswordGenerationAgent::HidePopup() {
   Send(new AutofillHostMsg_HidePasswordGenerationPopup(routing_id()));
 }
 
 }  // namespace autofill