Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4634)

Unified Diff: components/autofill/content/renderer/password_generation_agent.cc

Issue 774143003: [Password Generation] Remove requirement that generation fields are visible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/autofill/password_generation_agent_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/content/renderer/password_generation_agent.cc
diff --git a/components/autofill/content/renderer/password_generation_agent.cc b/components/autofill/content/renderer/password_generation_agent.cc
index 4585119080e017009c918f84a933b4052aa0b29f..4ed7c7c3a4cd20fcb23cc2b533f67ccfdffcf0de 100644
--- a/components/autofill/content/renderer/password_generation_agent.cc
+++ b/components/autofill/content/renderer/password_generation_agent.cc
@@ -42,10 +42,7 @@ bool GetAccountCreationPasswordFields(
for (size_t i = 0; i < control_elements.size(); i++) {
blink::WebInputElement* input_element =
toWebInputElement(&control_elements[i]);
- // Only pay attention to visible password fields.
- if (input_element &&
- input_element->isTextField() &&
- input_element->hasNonEmptyBoundingBox()) {
+ if (input_element && input_element->isTextField()) {
num_input_elements++;
if (input_element->isPasswordField())
passwords->push_back(*input_element);
« no previous file with comments | « chrome/renderer/autofill/password_generation_agent_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698