Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 772743003: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed)

Created:
6 years ago by RAGHURAM
Modified:
6 years ago
Reviewers:
haraken
CC:
blink-reviews, vsevik+blink_chromium.org, caseq+blink_chromium.org, arv+blink, pfeldman+blink_chromium.org, malch+blink_chromium.org, eustas+blink_chromium.org, sof, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, loislo+blink_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, blink-reviews-bindings_chromium.org, devtools-reviews_chromium.org, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/WebKit/Source/bindings This step is to move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/WebKit/Source/bindings (Ref: binding-methods changed: v8::Handle<v8::Object> wrapCustomElement(v8::Handle<v8::Object> creationContext, v8::Isolate*) static v8::Local<v8::Signature> installDOMClassTemplate(...) static v8::Handle<v8::Object> createExceptionDetails(v8::Handle<v8::Message>, v8::Isolate*)) BUG=424446 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186433

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -104 lines) Patch
M Source/bindings/core/v8/V8DOMConfiguration.h View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/V8DOMConfiguration.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/templates/interface_base.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/core/V8SVGTestInterface.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestException.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface2.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface3.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceConstructor2.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceConstructor3.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceConstructor4.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceCustomConstructor.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceDocument.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceEmpty.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceEventInitConstructor.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceEventTarget.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor2.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceNode.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestNode.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestObject.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestSpecialOperations.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestSpecialOperationsNotEnumerable.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestTypedefs.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/modules/V8TestInterface5.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M Source/core/dom/Element.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Element.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/JavaScriptCallFrame.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/JavaScriptCallFrame.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
RAGHURAM
Please review. Thanks & Regards
6 years ago (2014-12-02 13:52:50 UTC) #2
haraken
LGTM
6 years ago (2014-12-02 15:04:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/772743003/1
6 years ago (2014-12-03 14:38:32 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-03 15:50:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186433

Powered by Google App Engine
This is Rietveld 408576698