Source/bindings/tests/results/core/V8TestException.cpp - Issue 772743003: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/core/V8TestException.cpp

Issue 772743003: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/core/V8SVGTestInterface.cpp ('k') | Source/bindings/tests/results/core/V8TestInterface.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/core/V8TestException.cpp

diff --git a/Source/bindings/tests/results/core/V8TestException.cpp b/Source/bindings/tests/results/core/V8TestException.cpp

index 1905dc1fbbc2e99364772e0e1105c7699160589f..0edc9e3050e5171aebf49980f6f4b4a38ffa7349 100644

--- a/Source/bindings/tests/results/core/V8TestException.cpp

+++ b/Source/bindings/tests/results/core/V8TestException.cpp

@@ -82,11 +82,10 @@ static void installV8TestExceptionTemplate(v8::Handle<v8::FunctionTemplate> func

functionTemplate->ReadOnlyPrototype();

v8::Local<v8::Signature> defaultSignature;

- defaultSignature = V8DOMConfiguration::installDOMClassTemplate(functionTemplate, "TestException", v8::Local<v8::FunctionTemplate>(), V8TestException::internalFieldCount,

+ defaultSignature = V8DOMConfiguration::installDOMClassTemplate(isolate, functionTemplate, "TestException", v8::Local<v8::FunctionTemplate>(), V8TestException::internalFieldCount,

V8TestExceptionAttributes, WTF_ARRAY_LENGTH(V8TestExceptionAttributes),

0, 0,

- 0, 0,

- isolate);

+ 0, 0);

v8::Local<v8::ObjectTemplate> instanceTemplate = functionTemplate->InstanceTemplate();

ALLOW_UNUSED_LOCAL(instanceTemplate);

v8::Local<v8::ObjectTemplate> prototypeTemplate = functionTemplate->PrototypeTemplate();