Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Side by Side Diff: Source/core/inspector/JavaScriptCallFrame.h

Issue 772743003: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/dom/Element.cpp ('k') | Source/core/inspector/JavaScriptCallFrame.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2010, Google Inc. All rights reserved. 2 * Copyright (c) 2010, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 int scopeType(int scopeIndex) const; 65 int scopeType(int scopeIndex) const;
66 v8::Handle<v8::Value> thisObject() const; 66 v8::Handle<v8::Value> thisObject() const;
67 String stepInPositions() const; 67 String stepInPositions() const;
68 bool isAtReturn() const; 68 bool isAtReturn() const;
69 v8::Handle<v8::Value> returnValue() const; 69 v8::Handle<v8::Value> returnValue() const;
70 70
71 ScriptValue evaluateWithExceptionDetails(ScriptState*, const String& express ion, const ScriptValue& scopeExtension); 71 ScriptValue evaluateWithExceptionDetails(ScriptState*, const String& express ion, const ScriptValue& scopeExtension);
72 v8::Handle<v8::Value> restart(); 72 v8::Handle<v8::Value> restart();
73 ScriptValue setVariableValue(ScriptState*, int scopeNumber, const String& va riableName, const ScriptValue& newValue); 73 ScriptValue setVariableValue(ScriptState*, int scopeNumber, const String& va riableName, const ScriptValue& newValue);
74 74
75 static v8::Handle<v8::Object> createExceptionDetails(v8::Handle<v8::Message> , v8::Isolate*); 75 static v8::Handle<v8::Object> createExceptionDetails(v8::Isolate*, v8::Handl e<v8::Message>);
76 76
77 private: 77 private:
78 JavaScriptCallFrame(v8::Handle<v8::Context> debuggerContext, v8::Handle<v8:: Object> callFrame); 78 JavaScriptCallFrame(v8::Handle<v8::Context> debuggerContext, v8::Handle<v8:: Object> callFrame);
79 79
80 int callV8FunctionReturnInt(const char* name) const; 80 int callV8FunctionReturnInt(const char* name) const;
81 String callV8FunctionReturnString(const char* name) const; 81 String callV8FunctionReturnString(const char* name) const;
82 82
83 v8::Isolate* m_isolate; 83 v8::Isolate* m_isolate;
84 RefPtrWillBeMember<JavaScriptCallFrame> m_caller; 84 RefPtrWillBeMember<JavaScriptCallFrame> m_caller;
85 ScopedPersistent<v8::Context> m_debuggerContext; 85 ScopedPersistent<v8::Context> m_debuggerContext;
86 ScopedPersistent<v8::Object> m_callFrame; 86 ScopedPersistent<v8::Object> m_callFrame;
87 }; 87 };
88 88
89 } // namespace blink 89 } // namespace blink
90 90
91 #endif // JavaScriptCallFrame_h 91 #endif // JavaScriptCallFrame_h
OLDNEW
« no previous file with comments | « Source/core/dom/Element.cpp ('k') | Source/core/inspector/JavaScriptCallFrame.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698