Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Issue 772563003: Move many of v8_inspector dependencies out of core/ (Closed)

Created:
6 years ago by eseidel
Modified:
6 years ago
Reviewers:
yurys
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, esprehn, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Move many of v8_inspector dependencies out of core/ This doesn't fully separate v8_inspector from core, but it does lay the path. The next steps to removing v8_inspector is to remove all the # FIXME: Remove lines in the deps section of v8_inspector/BUILD.gn. gn check out/Debug v8_inspector will tell us if we've successfully removed all the dependencies. It's unclear if we want to remove the wtf dependency, but definitely all of the engine/core dependencies should be removed and presumably replaced with abstract interfaces which can be provided to v8_inspector by its host. Given the size of this patch (and that it's largely mechanical) I plan to TBR it. Most of this was done with tools/git/move_source_file.py BUG=435243 TBR=yurys@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/5b72a0c219d4310641365d65a38b9118ed14e6be

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+262 lines, -20415 lines) Patch
M sky/engine/bindings/core/v8/ScriptController.cpp View 1 chunk +1 line, -1 line 0 comments Download
D sky/engine/bindings/core/v8/ScriptDebugServer.h View 1 chunk +0 lines, -167 lines 0 comments Download
D sky/engine/bindings/core/v8/ScriptDebugServer.cpp View 1 chunk +0 lines, -715 lines 0 comments Download
D sky/engine/bindings/core/v8/ScriptPreprocessor.h View 1 chunk +0 lines, -62 lines 0 comments Download
D sky/engine/bindings/core/v8/ScriptPreprocessor.cpp View 1 chunk +0 lines, -115 lines 0 comments Download
M sky/engine/bindings/core/v8/ScriptProfiler.h View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/bindings/core/v8/ScriptProfiler.cpp View 2 chunks +0 lines, -36 lines 0 comments Download
D sky/engine/bindings/core/v8/ScriptRegexp.h View 1 chunk +0 lines, -57 lines 0 comments Download
D sky/engine/bindings/core/v8/ScriptRegexp.cpp View 1 chunk +0 lines, -107 lines 0 comments Download
M sky/engine/bindings/core/v8/V8Binding.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/bindings/core/v8/V8Initializer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/V8StringResource.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/bindings/core/v8/custom/V8InjectedScriptManager.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/bindings/core/v8/custom/V8WindowCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/v8.gypi View 2 chunks +6 lines, -12 lines 0 comments Download
M sky/engine/bindings/scripts/scripts.gni View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/BUILD.gn View 2 chunks +0 lines, -6 lines 0 comments Download
M sky/engine/core/core.gni View 2 chunks +0 lines, -24 lines 0 comments Download
M sky/engine/core/dom/Document.cpp View 2 chunks +1 line, -1 line 0 comments Download
M sky/engine/core/frame/Console.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/frame/FrameConsole.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/frame/LocalDOMWindow.cpp View 2 chunks +1 line, -1 line 0 comments Download
D sky/engine/core/inspector/AsyncCallStackTracker.h View 1 chunk +0 lines, -161 lines 0 comments Download
D sky/engine/core/inspector/AsyncCallStackTracker.cpp View 1 chunk +0 lines, -401 lines 0 comments Download
D sky/engine/core/inspector/BUILD.gn View 1 chunk +0 lines, -48 lines 0 comments Download
D sky/engine/core/inspector/BindingVisitors.h View 1 chunk +0 lines, -57 lines 0 comments Download
D sky/engine/core/inspector/CodeGeneratorInspector.py View 1 chunk +0 lines, -2364 lines 0 comments Download
D sky/engine/core/inspector/CodeGeneratorInspectorStrings.py View 1 chunk +0 lines, -956 lines 0 comments Download
D sky/engine/core/inspector/ContentSearchUtils.h View 1 chunk +0 lines, -58 lines 0 comments Download
D sky/engine/core/inspector/ContentSearchUtils.cpp View 1 chunk +0 lines, -188 lines 0 comments Download
D sky/engine/core/inspector/InjectedScript.h View 1 chunk +0 lines, -116 lines 0 comments Download
D sky/engine/core/inspector/InjectedScript.cpp View 1 chunk +0 lines, -341 lines 0 comments Download
D sky/engine/core/inspector/InjectedScriptBase.h View 1 chunk +0 lines, -77 lines 0 comments Download
D sky/engine/core/inspector/InjectedScriptBase.cpp View 1 chunk +0 lines, -192 lines 0 comments Download
M sky/engine/core/inspector/InjectedScriptHost.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
D sky/engine/core/inspector/InjectedScriptManager.h View 1 chunk +0 lines, -93 lines 0 comments Download
D sky/engine/core/inspector/InjectedScriptManager.cpp View 1 chunk +0 lines, -176 lines 0 comments Download
D sky/engine/core/inspector/InjectedScriptSource.js View 1 chunk +0 lines, -1731 lines 0 comments Download
D sky/engine/core/inspector/Inspector-1.1.json View 1 chunk +0 lines, -3981 lines 0 comments Download
D sky/engine/core/inspector/InspectorBaseAgent.h View 1 chunk +0 lines, -92 lines 0 comments Download
D sky/engine/core/inspector/InspectorBaseAgent.cpp View 1 chunk +0 lines, -57 lines 0 comments Download
D sky/engine/core/inspector/InspectorDebuggerAgent.h View 1 chunk +0 lines, -275 lines 0 comments Download
D sky/engine/core/inspector/InspectorDebuggerAgent.cpp View 1 chunk +0 lines, -1451 lines 0 comments Download
D sky/engine/core/inspector/InspectorFrontendChannel.h View 1 chunk +0 lines, -43 lines 0 comments Download
M sky/engine/core/inspector/InspectorNodeIds.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
D sky/engine/core/inspector/InspectorState.h View 1 chunk +0 lines, -117 lines 0 comments Download
D sky/engine/core/inspector/InspectorState.cpp View 1 chunk +0 lines, -171 lines 0 comments Download
M sky/engine/core/inspector/InspectorTraceEvents.cpp View 2 chunks +1 line, -1 line 0 comments Download
D sky/engine/core/inspector/InstrumentingAgents.h View 1 chunk +0 lines, -33 lines 0 comments Download
D sky/engine/core/inspector/JSONParser.h View 1 chunk +0 lines, -45 lines 0 comments Download
D sky/engine/core/inspector/JSONParser.cpp View 1 chunk +0 lines, -478 lines 0 comments Download
D sky/engine/core/inspector/PromiseTracker.h View 1 chunk +0 lines, -44 lines 0 comments Download
D sky/engine/core/inspector/PromiseTracker.cpp View 1 chunk +0 lines, -147 lines 0 comments Download
D sky/engine/core/inspector/ScriptBreakpoint.h View 1 chunk +0 lines, -56 lines 0 comments Download
M sky/engine/core/inspector/ScriptCallFrame.h View 2 chunks +1 line, -4 lines 0 comments Download
M sky/engine/core/inspector/ScriptCallFrame.cpp View 1 chunk +0 lines, -11 lines 0 comments Download
M sky/engine/core/inspector/ScriptCallStack.h View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/inspector/ScriptCallStack.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
D sky/engine/core/inspector/ScriptDebugListener.h View 1 chunk +0 lines, -89 lines 0 comments Download
D sky/engine/core/inspector/generate-inspector-protocol-version View 1 chunk +0 lines, -476 lines 0 comments Download
D sky/engine/core/inspector/protocol.json View 1 chunk +0 lines, -4372 lines 0 comments Download
A + sky/engine/v8_inspector/AsyncCallStackTracker.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + sky/engine/v8_inspector/AsyncCallStackTracker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/v8_inspector/BUILD.gn View 3 chunks +84 lines, -0 lines 0 comments Download
A + sky/engine/v8_inspector/CodeGeneratorInspector.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/engine/v8_inspector/CodeGeneratorInspectorStrings.py View 6 chunks +28 lines, -29 lines 0 comments Download
A + sky/engine/v8_inspector/ContentSearchUtils.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + sky/engine/v8_inspector/ContentSearchUtils.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + sky/engine/v8_inspector/InjectedScript.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + sky/engine/v8_inspector/InjectedScript.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + sky/engine/v8_inspector/InjectedScriptBase.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + sky/engine/v8_inspector/InjectedScriptBase.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + sky/engine/v8_inspector/InjectedScriptManager.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + sky/engine/v8_inspector/InjectedScriptManager.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + sky/engine/v8_inspector/InjectedScriptSource.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/engine/v8_inspector/Inspector-1.1.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/engine/v8_inspector/InspectorBaseAgent.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + sky/engine/v8_inspector/InspectorBaseAgent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + sky/engine/v8_inspector/InspectorDebuggerAgent.h View 3 chunks +10 lines, -12 lines 0 comments Download
A + sky/engine/v8_inspector/InspectorDebuggerAgent.cpp View 5 chunks +31 lines, -44 lines 0 comments Download
A + sky/engine/v8_inspector/InspectorFrontendChannel.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + sky/engine/v8_inspector/InspectorState.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + sky/engine/v8_inspector/InspectorState.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
A + sky/engine/v8_inspector/InstrumentingAgents.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + sky/engine/v8_inspector/JSONParser.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + sky/engine/v8_inspector/JSONParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/v8_inspector/PageDebuggerAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/v8_inspector/PageDebuggerAgent.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/v8_inspector/PageScriptDebugServer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/v8_inspector/PageScriptDebugServer.cpp View 3 chunks +4 lines, -7 lines 0 comments Download
A + sky/engine/v8_inspector/PromiseTracker.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + sky/engine/v8_inspector/PromiseTracker.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + sky/engine/v8_inspector/ScriptBreakpoint.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + sky/engine/v8_inspector/ScriptDebugListener.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + sky/engine/v8_inspector/ScriptDebugServer.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + sky/engine/v8_inspector/ScriptDebugServer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
A + sky/engine/v8_inspector/ScriptPreprocessor.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + sky/engine/v8_inspector/ScriptPreprocessor.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + sky/engine/v8_inspector/ScriptRegexp.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + sky/engine/v8_inspector/ScriptRegexp.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + sky/engine/v8_inspector/generate-inspector-protocol-version View 0 chunks +-1 lines, --1 lines 0 comments Download
M sky/engine/v8_inspector/inspector_backend_mojo.cc View 1 chunk +5 lines, -5 lines 0 comments Download
A + sky/engine/v8_inspector/protocol.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M sky/engine/web/WebLocalFrameImpl.cpp View 2 chunks +1 line, -1 line 0 comments Download
M tools/git/move_source_file.py View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
eseidel
6 years ago (2014-12-02 21:00:46 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5b72a0c219d4310641365d65a38b9118ed14e6be.

Powered by Google App Engine
This is Rietveld 408576698