Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: sky/engine/bindings/core/v8/ScriptProfiler.cpp

Issue 772563003: Move many of v8_inspector dependencies out of core/ (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/bindings/core/v8/ScriptProfiler.h ('k') | sky/engine/bindings/core/v8/ScriptRegexp.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/bindings/core/v8/ScriptProfiler.cpp
diff --git a/sky/engine/bindings/core/v8/ScriptProfiler.cpp b/sky/engine/bindings/core/v8/ScriptProfiler.cpp
index 7516639781a94c66593d70066d6995380f8295e8..c49626fb960851b94b9b3664bf92091870d7120e 100644
--- a/sky/engine/bindings/core/v8/ScriptProfiler.cpp
+++ b/sky/engine/bindings/core/v8/ScriptProfiler.cpp
@@ -38,7 +38,6 @@
#include "sky/engine/bindings/core/v8/V8Binding.h"
#include "sky/engine/bindings/core/v8/WrapperTypeInfo.h"
#include "sky/engine/core/dom/Document.h"
-#include "sky/engine/core/inspector/BindingVisitors.h"
#include "sky/engine/wtf/ThreadSpecific.h"
#include "v8/include/v8-profiler.h"
#include "v8/include/v8.h"
@@ -258,41 +257,6 @@ void ScriptProfiler::initialize()
profiler->SetWrapperClassInfoProvider(WrapperTypeInfo::NodeClassId, &retainedDOMInfo);
}
-void ScriptProfiler::visitNodeWrappers(WrappedNodeVisitor* visitor)
-{
- // visitNodeWrappers() should receive a ScriptState and retrieve an Isolate
- // from the ScriptState.
- v8::Isolate* isolate = v8::Isolate::GetCurrent();
- v8::HandleScope handleScope(isolate);
-
- class DOMNodeWrapperVisitor : public v8::PersistentHandleVisitor {
- public:
- DOMNodeWrapperVisitor(WrappedNodeVisitor* visitor, v8::Isolate* isolate)
- : m_visitor(visitor)
- , m_isolate(isolate)
- {
- }
-
- virtual void VisitPersistentHandle(v8::Persistent<v8::Value>* value, uint16_t classId) override
- {
- if (classId != WrapperTypeInfo::NodeClassId)
- return;
- // Casting to Handle is safe here, since the Persistent cannot get
- // GCd during visiting.
- v8::Handle<v8::Object>* wrapper = reinterpret_cast<v8::Handle<v8::Object>*>(value);
- ASSERT_UNUSED(m_isolate, V8Node::hasInstance(*wrapper, m_isolate));
- ASSERT((*wrapper)->IsObject());
- m_visitor->visitNode(V8Node::toNative(*wrapper));
- }
-
- private:
- WrappedNodeVisitor* m_visitor;
- v8::Isolate* m_isolate;
- } wrapperVisitor(visitor, isolate);
-
- v8::V8::VisitHandlesWithClassIds(&wrapperVisitor);
-}
-
ProfileNameIdleTimeMap* ScriptProfiler::currentProfileNameIdleTimeMap()
{
AtomicallyInitializedStatic(WTF::ThreadSpecific<ProfileNameIdleTimeMap>*, map = new WTF::ThreadSpecific<ProfileNameIdleTimeMap>);
« no previous file with comments | « sky/engine/bindings/core/v8/ScriptProfiler.h ('k') | sky/engine/bindings/core/v8/ScriptRegexp.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698