Fix icon on Windows XP taskbar

Fix icon on Windows XP taskbar

BUG=437829
Committed: https://crrev.com/0593c1690aeb6ac4869504b91d8172546aea1da6
Cr-Commit-Position: refs/heads/master@{#306389}

Committed: https://crrev.com/cd5b3ee6956e1c5adfe0c498c67213ebf17f60ce
Cr-Commit-Position: refs/heads/master@{#308326}

[Tomasz Moniuszko, 2014-12-01 15:51:14]

tmoniuszko@opera.com changed reviewers:
+ asvitkine@google.com, sky@chromium.org

[sky, 2014-12-01 17:35:52]

LGTM

https://codereview.chromium.org/772533002/diff/1/ui/gfx/win/window_impl.cc
File ui/gfx/win/window_impl.cc (right):

https://codereview.chromium.org/772533002/diff/1/ui/gfx/win/window_impl.cc#ne...
ui/gfx/win/window_impl.cc:265: return NULL;
If possible, nullptr every where.

[Tomasz Moniuszko, 2014-12-02 08:58:13]

The CQ bit was checked by tmoniuszko@opera.com

[commit-bot: I haz the power, 2014-12-02 08:59:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/772533002/20001

[commit-bot: I haz the power, 2014-12-02 10:46:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-02 10:46:04]

Try jobs failed on following builders:
  win_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...)

[Tomasz Moniuszko, 2014-12-02 15:04:03]

The CQ bit was checked by tmoniuszko@opera.com

[commit-bot: I haz the power, 2014-12-02 15:05:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/772533002/20001

[commit-bot: I haz the power, 2014-12-02 15:49:00]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-12-02 15:49:47]

Patchset 2 (id:??) landed as
https://crrev.com/0593c1690aeb6ac4869504b91d8172546aea1da6
Cr-Commit-Position: refs/heads/master@{#306389}

[sky, 2014-12-04 16:01:46]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/780913002/ by sky@chromium.org.

The reason for reverting is: Likely results in 438980..

[Tomasz Moniuszko, 2014-12-10 12:59:56]

On 2014/12/04 16:01:46, sky wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/780913002/ by mailto:sky@chromium.org.
> 
> The reason for reverting is: Likely results in 438980..

Patch set 3 includes fix for 438980 (regression).

[sky, 2014-12-10 16:54:43]

Can you upload a patch with the patch you landed rebased to trunk, and then your
fix on top of that? That way it's easy for me to see the diffs.

[Tomasz Moniuszko, 2014-12-11 11:14:36]

On 2014/12/10 16:54:43, sky wrote:
> Can you upload a patch with the patch you landed rebased to trunk, and then
your
> fix on top of that? That way it's easy for me to see the diffs.

Done.

[sky, 2014-12-11 15:51:23]

https://codereview.chromium.org/772533002/diff/80001/chrome/browser/ui/views/...
File chrome/browser/ui/views/frame/glass_browser_frame_view.cc (right):

https://codereview.chromium.org/772533002/diff/80001/chrome/browser/ui/views/...
chrome/browser/ui/views/frame/glass_browser_frame_view.cc:76: HICON
CreateHICONFromSkBitmap(const gfx::ImageSkia& image, int width,
Make sure to run git cl format.

https://codereview.chromium.org/772533002/diff/80001/chrome/browser/ui/views/...
chrome/browser/ui/views/frame/glass_browser_frame_view.cc:76: HICON
CreateHICONFromSkBitmap(const gfx::ImageSkia& image, int width,
Add description of this. Also, it should be renamed to better indicate what it
does. Maybe something like CreateHICONFromSkBitmapSizedTo.

https://codereview.chromium.org/772533002/diff/80001/chrome/browser/ui/views/...
chrome/browser/ui/views/frame/glass_browser_frame_view.cc:78: if (width ==
image.width() && height == image.height()) {
nit: no {}

[Tomasz Moniuszko, 2014-12-12 11:47:07]

https://codereview.chromium.org/772533002/diff/80001/chrome/browser/ui/views/...
File chrome/browser/ui/views/frame/glass_browser_frame_view.cc (right):

https://codereview.chromium.org/772533002/diff/80001/chrome/browser/ui/views/...
chrome/browser/ui/views/frame/glass_browser_frame_view.cc:76: HICON
CreateHICONFromSkBitmap(const gfx::ImageSkia& image, int width,
On 2014/12/11 15:51:23, sky wrote:
> Make sure to run git cl format.

Done.

https://codereview.chromium.org/772533002/diff/80001/chrome/browser/ui/views/...
chrome/browser/ui/views/frame/glass_browser_frame_view.cc:76: HICON
CreateHICONFromSkBitmap(const gfx::ImageSkia& image, int width,
On 2014/12/11 15:51:23, sky wrote:
> Add description of this. Also, it should be renamed to better indicate what it
> does. Maybe something like CreateHICONFromSkBitmapSizedTo.

Done.

https://codereview.chromium.org/772533002/diff/80001/chrome/browser/ui/views/...
chrome/browser/ui/views/frame/glass_browser_frame_view.cc:78: if (width ==
image.width() && height == image.height()) {
On 2014/12/11 15:51:23, sky wrote:
> nit: no {}

Done.

[sky, 2014-12-12 16:28:45]

LGTM

[Tomasz Moniuszko, 2014-12-15 08:06:23]

The CQ bit was checked by tmoniuszko@opera.com

[commit-bot: I haz the power, 2014-12-15 08:06:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/772533002/100001

[commit-bot: I haz the power, 2014-12-15 08:51:12]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2014-12-15 08:51:53]

Patchset 6 (id:??) landed as
https://crrev.com/cd5b3ee6956e1c5adfe0c498c67213ebf17f60ce
Cr-Commit-Position: refs/heads/master@{#308326}