Issue 780913002: Revert of Fix icon on Windows XP taskbar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 780913002: Revert of Fix icon on Windows XP taskbar (Closed)

Created:
6 years ago by sky

Modified:
6 years ago

Reviewers:
asvitkine_google, Tomasz Moniuszko

CC:
chromium-reviews, tfarina

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Revert of Fix icon on Windows XP taskbar (patchset #2 id:20001 of https://codereview.chromium.org/772533002/) Reason for revert: Likely results in 438980. Original issue's description: > Fix icon on Windows XP taskbar > > BUG=437829 > > Committed: https://crrev.com/0593c1690aeb6ac4869504b91d8172546aea1da6 > Cr-Commit-Position: refs/heads/master@{#306389} TBR=asvitkine@google.com,tmoniuszko@opera.com NOTREECHECKS=true NOTRY=true BUG=437829 Committed: https://crrev.com/c0841d5f525f5268276fc365d068a518ab7554aa Cr-Commit-Position: refs/heads/master@{#306823}

Created: 6 years ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -45 lines)			Patch
M	chrome/browser/app_icon_win.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/app_icon_win.cc	View	1 chunk	+0 lines, -11 lines	0 comments	Download
M	chrome/browser/ui/views/chrome_views_delegate.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/chrome_views_delegate.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	ui/gfx/win/window_impl.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/gfx/win/window_impl.cc	View	4 chunks	+5 lines, -12 lines	0 comments	Download
M	ui/views/test/test_views_delegate.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	ui/views/views_delegate.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	ui/views/win/hwnd_message_handler.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/views/win/hwnd_message_handler.cc	View	1 chunk	+2 lines, -9 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/780913002/1

6 years ago (2014-12-04 16:03:10 UTC) #2

commit-bot: I haz the power

6 years ago (2014-12-04 16:06:05 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/c0841d5f525f5268276fc365d068a518ab7554aa
Cr-Commit-Position: refs/heads/master@{#306823}