Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Unified Diff: ui/gfx/win/window_impl.cc

Issue 772533002: Fix icon on Windows XP taskbar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add some doc + git cl format Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gfx/win/window_impl.h ('k') | ui/views/test/test_views_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/win/window_impl.cc
diff --git a/ui/gfx/win/window_impl.cc b/ui/gfx/win/window_impl.cc
index b0c4fa7ad34349c7e10bb7a5663d13287ee65cec..5820ed64a6e8a555f98a051e1c7734213775bff3 100644
--- a/ui/gfx/win/window_impl.cc
+++ b/ui/gfx/win/window_impl.cc
@@ -33,10 +33,10 @@ const wchar_t* const WindowImpl::kBaseClassName = L"Chrome_WidgetWin_";
struct ClassInfo {
UINT style;
HICON icon;
+ HICON small_icon;
- ClassInfo(int style, HICON icon)
- : style(style),
- icon(icon) {}
+ ClassInfo(int style, HICON icon, HICON small_icon)
+ : style(style), icon(icon), small_icon(small_icon) {}
// Compares two ClassInfos. Returns true if all members match.
bool Equals(const ClassInfo& other) const {
@@ -126,17 +126,10 @@ ATOM ClassRegistrar::RetrieveClassAtom(const ClassInfo& class_info) {
WNDCLASSEX window_class;
base::win::InitializeWindowClass(
- name.c_str(),
- &base::win::WrappedWindowProc<WindowImpl::WndProc>,
- class_info.style,
- 0,
- 0,
- NULL,
- reinterpret_cast<HBRUSH>(GetStockObject(BLACK_BRUSH)),
- NULL,
- class_info.icon,
- class_info.icon,
- &window_class);
+ name.c_str(), &base::win::WrappedWindowProc<WindowImpl::WndProc>,
+ class_info.style, 0, 0, NULL,
+ reinterpret_cast<HBRUSH>(GetStockObject(BLACK_BRUSH)), NULL,
+ class_info.icon, class_info.small_icon, &window_class);
HMODULE instance = window_class.hInstance;
ATOM atom = RegisterClassEx(&window_class);
CHECK(atom) << GetLastError();
@@ -256,7 +249,11 @@ void WindowImpl::Init(HWND parent, const Rect& bounds) {
}
HICON WindowImpl::GetDefaultWindowIcon() const {
- return NULL;
+ return nullptr;
+}
+
+HICON WindowImpl::GetSmallWindowIcon() const {
+ return nullptr;
}
LRESULT WindowImpl::OnWndProc(UINT message, WPARAM w_param, LPARAM l_param) {
@@ -305,7 +302,8 @@ LRESULT CALLBACK WindowImpl::WndProc(HWND hwnd,
ATOM WindowImpl::GetWindowClassAtom() {
HICON icon = GetDefaultWindowIcon();
- ClassInfo class_info(initial_class_style(), icon);
+ HICON small_icon = GetSmallWindowIcon();
+ ClassInfo class_info(initial_class_style(), icon, small_icon);
return ClassRegistrar::GetInstance()->RetrieveClassAtom(class_info);
}
« no previous file with comments | « ui/gfx/win/window_impl.h ('k') | ui/views/test/test_views_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698