Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Unified Diff: chrome/browser/ui/cocoa/infobars/infobar_controller_unittest.mm

Issue 7712008: Refactor and clean up code now that chrome::testing::NSRunLoopRunAllPending() exists. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update gtest_exclude Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/infobars/infobar_controller_unittest.mm
diff --git a/chrome/browser/ui/cocoa/infobars/infobar_controller_unittest.mm b/chrome/browser/ui/cocoa/infobars/infobar_controller_unittest.mm
index 865a4c309c28a6416f17c37095295e86410341fb..460345d0287aa0f5353d0f9e6a43d565bf6d94de 100644
--- a/chrome/browser/ui/cocoa/infobars/infobar_controller_unittest.mm
+++ b/chrome/browser/ui/cocoa/infobars/infobar_controller_unittest.mm
@@ -13,6 +13,7 @@
#import "chrome/browser/ui/cocoa/infobars/infobar_controller.h"
#include "chrome/browser/ui/cocoa/infobars/mock_confirm_infobar_delegate.h"
#include "chrome/browser/ui/cocoa/infobars/mock_link_infobar_delegate.h"
+#include "chrome/browser/ui/cocoa/run_loop_testing.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "testing/platform_test.h"
@@ -197,8 +198,7 @@ TEST_F(LinkInfoBarControllerTest, ShowAndClickLink) {
// Spin the runloop because the invocation for closing the infobar is done on
// a 0-timer delayed selector.
- [[NSRunLoop currentRunLoop] runUntilDate:
- [NSDate dateWithTimeIntervalSinceNow:0.1]];
Mark Mentovai 2011/08/22 19:44:57 ha.
+ chrome::testing::NSRunLoopRunAllPending();
ASSERT_TRUE(delegate_closed());
EXPECT_TRUE(closed_delegate_link_clicked_);
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698