Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 771033003: Revert of Use weak cells in map checks in polymorphic ICs. (Closed)

Created:
6 years ago by Michael Achenbach
Modified:
6 years ago
CC:
v8-dev, Hannes Payer (out of office), Toon Verwaest, Jakob Kummerow
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Revert of Use weak cells in map checks in polymorphic ICs. (patchset #8 id:140001 of https://codereview.chromium.org/753993003/) Reason for revert: [Sheriff] Speculative revert for breaking chromium asan (roll blocker): http://build.chromium.org/p/client.v8/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/1683 Original issue's description: > Use weak cells in map checks in polymorphic ICs. > > BUG=v8:3663 > LOG=N TBR=mvstanton@chromium.org,akos.palfi@imgtec.com,weiliang.lin@intel.com,ulan@chromium.org NOTREECHECKS=true NOTRY=true BUG=v8:3663

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -415 lines) Patch
M src/arm/macro-assembler-arm.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 1 chunk +0 lines, -7 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M src/factory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/objects-visiting-inl.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +0 lines, -7 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M src/ic/arm/ic-compiler-arm.cc View 2 chunks +6 lines, -8 lines 0 comments Download
M src/ic/arm64/ic-compiler-arm64.cc View 2 chunks +5 lines, -8 lines 0 comments Download
M src/ic/ia32/ic-compiler-ia32.cc View 2 chunks +5 lines, -9 lines 0 comments Download
M src/ic/mips/ic-compiler-mips.cc View 2 chunks +6 lines, -12 lines 0 comments Download
M src/ic/mips64/ic-compiler-mips64.cc View 2 chunks +6 lines, -12 lines 0 comments Download
M src/ic/x64/ic-compiler-x64.cc View 2 chunks +6 lines, -9 lines 0 comments Download
M src/ic/x87/ic-compiler-x87.cc View 2 chunks +4 lines, -8 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +0 lines, -7 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 chunk +0 lines, -7 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M src/objects.h View 3 chunks +1 line, -5 lines 0 comments Download
M src/objects.cc View 8 chunks +10 lines, -57 lines 0 comments Download
M src/objects-inl.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects-printer.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +0 lines, -7 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M src/x87/macro-assembler-x87.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M test/cctest/cctest.status View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-heap.cc View 5 chunks +0 lines, -114 lines 0 comments Download
M test/mjsunit/opt-elements-kind.js View 1 chunk +3 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Achenbach
Created Revert of Use weak cells in map checks in polymorphic ICs.
6 years ago (2014-12-02 08:13:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/771033003/1
6 years ago (2014-12-02 08:13:23 UTC) #2
commit-bot: I haz the power
Failed to apply patch for src/mips/macro-assembler-mips.cc: While running git apply --index -3 -p1; error: patch ...
6 years ago (2014-12-02 08:13:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/771033003/1
6 years ago (2014-12-02 08:16:24 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-02 08:16:51 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698